Closed Bug 1810019 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 37916 - Revert "[view-timeline]: Update naming for delay as timeline offset"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37916 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37916
Details from upstream follow.

luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> wrote:

Revert "[view-timeline]: Update naming for delay as timeline offset"

This reverts commit 8c67ecf3a1d46af987a2097bfa685fdc00937b43.

Reason for revert:
LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8792142657514411521

Sample failed build: https://ci.chromium.org/b/8792142657514411521

If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8792142657514411521&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4081107

Original change's description:

[view-timeline]: Update naming for delay as timeline offset

Patch implements rename based on most recent recommendation in
https://github.com/w3c/csswg-drafts/issues/7589.

Next steps:

  • CSS support for animation-range.
  • Support for % delays.
  • Support for range(Start|End) as string in animation effect timing options.
  • Removal of \<name> \<percent> from animation-delay.
  • Support range(Start|End) as CSSNumericValue (offset only with implied 'cover' as named range).

Bug: 1383162
Change-Id: I9d2e9572aac31c79fb937514c1f65e6940a9e27e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4081107
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092031}

Bug: 1383162
Change-Id: Id7c8f3ca84675b454d14a18a45aa1895c87d303f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4162958
WPT-Export-Revision: 4d0118a7c51650add57cedcac5980e1ee66441f5

PR 37916 applied with additional changes from upstream: 118edd76ea99877545f88e9e313bcb88d5c9e430

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

OK : 14
PASS : 4
FAIL : 72
ERROR: 1

Chrome

OK : 15
PASS : 82
FAIL : 1

Safari

OK : 14
PASS : 4
FAIL : 72
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-animations/parsing/animation-delay-end-computed.html [wpt.fyi]
    • Property animation-delay-start value 'initial': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value '-500ms': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'calc(2 * 3s)': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value '20s, 10s': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 0%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'COVER 0%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 100%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 120%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover -42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'contain 42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'exit 42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'exit calc(41% + 1%)': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'exit 1%, cover 2%, contain 100%': FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-animations/parsing/animation-delay-shorthand-computed.html [wpt.fyi]
    • Property animation-delay value '1s 2s': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value '1s 2s, 3s': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value '1s, 2s 3s': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'cover': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'contain': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'enter': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'exit': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'enter, exit': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'enter 0% enter 100%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'exit 0% exit 100%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'cover 0% cover 100%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'contain 0% contain 100%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'cover 50%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'contain 50%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'enter 50%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'exit 50%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'enter 50% 0s': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value '0s enter 50%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'enter 50% exit 50%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay value 'cover 50% enter 50%, contain 50% exit 50%': FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-animations/parsing/animation-delay-start-computed.html [wpt.fyi]
    • Property animation-delay-start value 'initial': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value '-500ms': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'calc(2 * 3s)': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value '20s, 10s': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 0%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'COVER 0%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 100%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 120%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover 42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'cover -42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'contain 42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'exit 42%': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'exit calc(41% + 1%)': FAIL (Chrome: PASS, Safari: FAIL)
    • Property animation-delay-start value 'exit 1%, cover 2%, contain 100%': FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/css/view-timeline-delay-animation.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • /scroll-animations/view-timelines/block-view-timeline-current-time-vertical-rl.tentative.html [wpt.fyi]
    • View timeline with container having vertical-rl layout: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/block-view-timeline-current-time.tentative.html [wpt.fyi]
    • View timeline with start and end scroll offsets that do not align with the scroll boundaries: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline does not clamp starting scroll offset at 0: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline does not clamp end scroll offset at max scroll: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/block-view-timeline-nested-subject.tentative.html [wpt.fyi]
    • View timeline with subject that is not a direct descendant of the scroll container: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/inline-view-timeline-current-time.tentative.html [wpt.fyi]
    • View timeline with start and end scroll offsets that do not align with the scroll boundaries: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline does not clamp starting scroll offset at 0: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline does not clamp end scroll offset at max scroll: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline with container having RTL layout: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-delay-large-subject.html [wpt.fyi]
    • View timeline with range set via delays.: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-delay.html [wpt.fyi]
    • View timeline with range set via delays.: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-get-current-time-range-name.html [wpt.fyi]
    • View timeline current time for named range: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-inset.html [wpt.fyi]
    • View timeline with px based inset.: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline with percent based inset.: FAIL (Chrome: PASS, Safari: FAIL)
    • view timeline with inset auto.: FAIL (Chrome: PASS, Safari: FAIL)
    • view timeline with font relative inset.: FAIL (Chrome: PASS, Safari: FAIL)
    • view timeline with viewport relative insets.: FAIL (Chrome: FAIL, Safari: FAIL)
    • view timeline inset as string: FAIL (Chrome: PASS, Safari: FAIL)
    • view timeline with invalid inset: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-snapport.html [wpt.fyi]
    • Default ViewTimeline is not affected by scroll-padding: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-source.tentative.html [wpt.fyi]
    • Default source for a View timeline is the nearest scroll ancestor to the subject: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline ignores explicitly set source: FAIL (Chrome: PASS, Safari: FAIL)
    • View timeline source is null when display:none: FAIL (Chrome: PASS, Safari: FAIL)
  • /scroll-animations/view-timelines/view-timeline-subject-size-changes.html [wpt.fyi]
    • View timeline with subject size change after the creation of the animation: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/697a57fd6be1
[wpt PR 37916] - Revert "[view-timeline]: Update naming for delay as timeline offset", a=testonly

https://hg.mozilla.org/mozilla-central/rev/697a57fd6be1

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.