1810025 - Tabbrowser's tab label long data URI truncation code doesn't truncate initial label for a tab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (he/him)]

See bug 1800596 for context.

I have a patch for this.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1810025 - ensure long data URIs are never fully present in the tab label, r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37f190953238
ensure long data URIs are never fully present in the tab label, r=dao

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/37f190953238

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[:Gijs (he/him)]

Comment on attachment 9312076 [details]
Bug 1810025 - ensure long data URIs are never fully present in the tab label, r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Perf problems opening huge data URIs
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Moved/refactored a small amount of existing JS, early in the beta cycle still, has automated test
• String changes made/needed: Nope
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9312076 [details]
Bug 1810025 - ensure long data URIs are never fully present in the tab label, r?dao

Approved for 110 beta 4, thanks.

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a766035681e3