Closed Bug 1810025 Opened 16 days ago Closed 10 days ago

Tabbrowser's tab label long data URI truncation code doesn't truncate initial label for a tab

Categories

(Firefox :: Tabbed Browser, defect)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox110 --- fixed
firefox111 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

See bug 1800596 for context.

I have a patch for this.

Depends on: 1408854
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/37f190953238
ensure long data URIs are never fully present in the tab label, r=dao
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(gijskruitbosch+bugs)

Comment on attachment 9312076 [details]
Bug 1810025 - ensure long data URIs are never fully present in the tab label, r?dao

Beta/Release Uplift Approval Request

  • User impact if declined: Perf problems opening huge data URIs
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Moved/refactored a small amount of existing JS, early in the beta cycle still, has automated test
  • String changes made/needed: Nope
  • Is Android affected?: No
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9312076 - Flags: approval-mozilla-beta?

Comment on attachment 9312076 [details]
Bug 1810025 - ensure long data URIs are never fully present in the tab label, r?dao

Approved for 110 beta 4, thanks.

Attachment #9312076 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.