1810101 - Use "add_task()" instead of "add_test()" in Remote Protocols xpcshell tests

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All of our xpcshell tests currently use the "add_test()" function which require the line run_next_test(); to be added at the end of the test:

https://searchfox.org/mozilla-central/search?q=add_test&path=remote%2F&case=false&regexp=false

We should switch to add_task() which doesn't need it and better works with async test code.

Comment 1

[ofrazy]

Hello, I am new here but I have found interest in this bug and I would love to solve it, how do I go about it? I'd love to contribute to this project.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

You are welcome to get started! I would suggest that you have a look at our general documentation in how to get started:
https://firefox-source-docs.mozilla.org/remote/index.html

If something is unclear don't hesitate to ask here, or join us on Element / Matrix as described in the docs. Thanks.

Comment 3

[ofrazy]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] (away 02/13 - 02/19) from comment #2)

You are welcome to get started! I would suggest that you have a look at our general documentation in how to get started:
https://firefox-source-docs.mozilla.org/remote/index.html

If something is unclear don't hesitate to ask here, or join us on Element / Matrix as described in the docs. Thanks.

Hello Henrik,
So I've just looked at the codebase on GitHub and I have managed to track the files that need the changes, should I fork the repo and then link the bug once I am done, or there is another process that I should follow to fix the issue addressed in this bug?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On Github we only have a copy of the source. Check the following pages specifically in how to get started:

https://firefox-source-docs.mozilla.org/testing/marionette/NewContributors.html
https://firefox-source-docs.mozilla.org/testing/marionette/Building.html

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

ofrazy, are you still interested to work on this bug? Is there anything blocking you and where I can help? Please let me know.

Comment 6

[ofrazy]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #5)

ofrazy, are you still interested to work on this bug? Is there anything blocking you and where I can help? Please let me know.

Yes, I am interested

I had lost hold of my devices, I am currently setting up my environment I will be in contact with you on element incase of any issues.

Comment 7

[ofrazy]

Attachment: Bug 1810101 - [remote] Use add_task() instead of add_test() for xpcshell tests.

Comment 8

[ofrazy]

Attachment: Bug 1810101 - Use async for all instances of add_task()

Depends on D170809

Comment 9

[ofrazy]

Attachment: Bug 1810101 -Use async for instances of add_task()

Depends on D170809

Comment 10

[ofrazy]

Attachment: Bug 1810101 - Fixed highlighted errors by reviewer

Depends on D170809

Comment 11

[ofrazy]

Attachment: Bug 1810101 use add_task() instead of add_test()

Depends on D171059

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d55d82d13a8
[remote] Use add_task() instead of add_test() for xpcshell tests. r=webdriver-reviewers,whimboo

Comment 13

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2d55d82d13a8