1810169 - BaseBrowserFragment uses fixed selected session to initialize UI

Status: NEW

(Firefox for Android :: General, task, P3)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/14215.

https://github.com/mozilla-mobile/fenix/blob/master/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt#L211-L638

protected open fun initializeUI(view: View): Session? {
  return getSessionById()?.also { session ->
    // ...
  }
}

This code is problematic. getSessionById() returns the fixed session (e.g. in a custom tab) or the selected tab (sessionManager.selectedSession). The selected tab can change during the lifetime of the fragment and so we shouldn't use it to initialize the UI once.

Luckily there's only one place where the session parameter is used. So this may not be a big project to refactor.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.