1810171 - [wdspec] Add missing timestamp assertion in assert_navigation_info

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On bug 1790378 I've added the new timestamp property to the navigation events. As noticed by Maksim on the upstream PR we miss the actual assertion for the timestamp.

https://searchfox.org/mozilla-central/rev/893a8f062ec6144c84403fbfb0a57234418b89cf/testing/web-platform/tests/webdriver/tests/bidi/browsing_context/__init__.py#44-62

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1810171 - [wdspec] Add missing assertion for navigation event's timestamp.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1810171 - [wdspec] Add missing assertion for navigation event's timestamp.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6813678e069
[wdspec] Add missing assertion for navigation event's timestamp. r=webdriver-reviewers,jdescottes

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37944 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d6813678e069

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Is this the correct format for the assertion? At the top of the function, it's indicated timestamp is expected to be an integer.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #6)

Is this the correct format for the assertion? At the top of the function, it's indicated timestamp is expected to be an integer.

Yes, integer is the default but for specific timestamp related checks we actually pass in a time interval given that we cannot check for exact timestamps.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham