Closed
Bug 1810245
Opened 2 years ago
Closed 3 months ago
Handle getters and custom data properties without an IC in Ion
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1878158
People
(Reporter: alexical, Assigned: alexical)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
We should be able to just tweak the megamorphic cache slightly to allow us to, from a new MIR op, gracefully fall back to a VM call in the case where a megamorphic GetProp/GetElem has a cache miss. Our failure to do this results in us transitioning to a generic mode IC, which shows up in Speedometer profiles as IonGetPropertyIC::update.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
|
||
Updated•2 years ago
|
Severity: -- → S3
Priority: -- → P1
|
||
Updated•2 years ago
|
Whiteboard: [sp3]
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-229
|
|
||
Comment 1•1 year ago
|
||
(Re-prioritizing P1 bugs)
Severity: S3 → N/A
Type: task → enhancement
Priority: P1 → P3
|
||
Comment 2•1 year ago
|
||
Hey Alex,
This seems like an interesting bug for me to explore, I am totally new contributor to SM could you guide as to what areas of the code i can read for this this? is there any previous revision implementing something similar and is there a code sample with which we can emulate this cache miss?
Thank you!
Flags: needinfo?(dothayer)
|
||
Comment 3•3 months ago
|
||
This work was done in bug 1878158.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Duplicate of bug: 1878158
Flags: needinfo?(dothayer)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•