Closed Bug 1810317 Opened 3 years ago Closed 3 years ago

Update libjxl to new version 27f0ffaf77ca9d08222bb17406483ae4509de4dd from 2023-01-13 06:02:06

Categories

(Core :: Graphics: ImageLib, enhancement)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: update-bot, Assigned: saschanaz)

References

Details

(Whiteboard: [3pl-filed][task_id: CjIk0ohrS0mOQtJjwYfn5A])

Attachments

(1 external file)

This update covers 16 commits:

27f0ffaf77ca9d08222bb17406483ae4509de4dd by Moritz Firsching

https://github.com/libjxl/libjxl/commit/27f0ffaf77ca9d08222bb17406483ae4509de4dd
Authored: 2023-01-13 17:02:06 +1100
Committed: 2023-01-13 07:02:06 +0100

Avoid EnumValid as much as possible (#2044)

We change the order of evaluations in some if statements in order to
avoid calling EnumValid when it is in fact not valid, e.g. when
color_primaries==12.

Files Modified:

  • lib/jxl/enc_color_management.cc

cf939d796868804e4844fb3a4a5cbc755fb82d90 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/cf939d796868804e4844fb3a4a5cbc755fb82d90
Authored: 2023-01-12 14:02:01 +0100
Committed: 2023-01-12 19:57:43 +0100

Use input scan script in jpegli encoder.

Files Modified:

  • lib/jpegli/encode.cc
  • lib/jpegli/encode_api_test.cc

96dc2519ea2719785503f5d6a8db893c349beb7d by Evgenii Kliuchnikov

https://github.com/libjxl/libjxl/commit/96dc2519ea2719785503f5d6a8db893c349beb7d
Authored: 2023-01-12 11:20:26 +0000
Committed: 2023-01-12 16:13:50 +0100

Bump version in more places

Drive-by: ramp-up soversion as well

Files Modified:

  • .github/workflows/conformance.yml
  • ci.sh
  • lib/CMakeLists.txt

a625bd62f37727c8ec73ea14644b5080a5a95ceb by Evgenii Kliuchnikov

https://github.com/libjxl/libjxl/commit/a625bd62f37727c8ec73ea14644b5080a5a95ceb
Authored: 2023-01-12 13:06:39 +0000
Committed: 2023-01-12 15:51:13 +0100

Fix Lexan build

Files Modified:

  • lib/jxl/enc_fast_lossless.cc

c6e91cf84428b30dd8dd2b9afa285ad03f1bafa6 by Evgenii Kliuchnikov

https://github.com/libjxl/libjxl/commit/c6e91cf84428b30dd8dd2b9afa285ad03f1bafa6
Authored: 2023-01-12 10:28:27 +0000
Committed: 2023-01-12 12:10:47 +0100

Fill missing changelog entries

Files Modified:

  • CHANGELOG.md

d8f6d06734540c4d9702466d169006179bdded80 by Evgenii Kliuchnikov

https://github.com/libjxl/libjxl/commit/d8f6d06734540c4d9702466d169006179bdded80
Authored: 2023-01-11 16:13:10 +0000
Committed: 2023-01-12 10:48:25 +0100

Bump version to 0.9

Files Modified:

  • debian/changelog
  • lib/CMakeLists.txt
  • lib/lib.gni

d178d552887e4a1c38852deb95937a1703238b03 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/d178d552887e4a1c38852deb95937a1703238b03
Authored: 2023-01-11 17:58:30 +0100
Committed: 2023-01-12 09:17:38 +0100

Change extras::EncodeJpeg to take PackedPixelFile as input.

This is consistent with the extras::DecodeJpeg API as well as the rest of
the codec APIs in lib/extras.

Files Modified:

  • lib/extras/codec_test.cc
  • lib/extras/enc/encode.cc
  • lib/extras/enc/encode.h
  • lib/extras/enc/jpegli.cc
  • lib/extras/enc/jpegli.h
  • tools/benchmark/benchmark_codec_jpeg.cc
  • tools/cjpeg_hdr.cc

4fa7542cd66ddd0685c1e8dd9a6110db1700c57c by Luca Versari

https://github.com/libjxl/libjxl/commit/4fa7542cd66ddd0685c1e8dd9a6110db1700c57c
Authored: 2023-01-11 23:45:00 +0100
Committed: 2023-01-12 08:46:10 +0100

Fix out-of-bounds vector access in fast_lossless.

Thanks to @Maximus- for pointing this out.

Files Modified:

  • lib/jxl/enc_fast_lossless.cc

77c1a0d73f9f7b716df96bf80ccb1d1804c4cb82 by Eugene Kliuchnikov

https://github.com/libjxl/libjxl/commit/77c1a0d73f9f7b716df96bf80ccb1d1804c4cb82
Authored: 2023-01-11 16:46:04 +0100
Committed: 2023-01-11 17:21:50 +0100

Fix typo

Files Modified:

  • doc/release.md

2866f26dc533777c126414fb8045c163bcded1b1 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/2866f26dc533777c126414fb8045c163bcded1b1
Authored: 2023-01-10 18:00:17 +0100
Committed: 2023-01-11 09:16:48 +0100

Support jpegli encoding and/or decoding in benchmark_xl.

With this change it is possible to set jpegli encoding and
decoding independently from each other and thus benchmark
all combinations.

The distance-dependent hf_asymmetry setting is removed from
the benchmark because we would get different butteraugli
scores if we set a quality or the corresponding distance.

Example benchmark output:

Encoding                                   kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm  SSIMULACRA2        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------------------------------------------
jpeg:q90                                     13270  4838710    2.9169834  34.812  91.189   2.40070152  91.22219875   0.68663652  2.002907346332      0
jpeg:q90:dec-jpegli                          13270  4838710    2.9169834  33.531  48.241   2.17603207  91.91514122   0.62092407  1.811225220820      0
jpeg:q90:dec-jpegli:bd16                     13270  4838710    2.9169834  34.090  48.448   2.16807747  92.09963416   0.61567342  1.795909185459      0
jpeg:enc-jpegli:q90                          13270  3953955    2.3836149   4.803  32.236   1.91680062  87.25370857   0.65623731  1.564217042271      0
jpeg:enc-jpegli:q90:dec-jpegli               13270  3953955    2.3836149   5.086  21.595   1.81215000  87.94607988   0.62230139  1.483326878403      0
jpeg:enc-jpegli:q90:dec-jpegli:bd16          13270  3953955    2.3836149   4.869  21.566   1.82237017  88.14496047   0.61435296  1.464380876154      0
jpeg:enc-jpegli:xyb:q90                      13270  2943200    1.7742881   5.849  43.061   2.09280968  82.67326926   0.75413047  1.338044730787      0
jpeg:enc-jpegli:xyb:q90:dec-jpegli           13270  2943200    1.7742881   5.857  28.072   2.14005589  82.48235289   0.74338715  1.318982986140      0
jpeg:enc-jpegli:xyb:q90:dec-jpegli:bd16      13270  2943200    1.7742881   5.792  23.014   2.14104915  83.03747962   0.72821837  1.292069207287      0
Aggregate:                                   13270  3832896    2.3106353   9.930  35.477   2.06657864  87.34055844   0.66911701  1.546085363235      0

Files Modified:

  • lib/jpegli/encode.cc
  • lib/jpegli/encode.h
  • tools/benchmark/benchmark_args.cc
  • tools/benchmark/benchmark_args.h
  • tools/benchmark/benchmark_codec.cc
  • tools/benchmark/benchmark_codec.h
  • tools/benchmark/benchmark_codec_custom.cc
  • tools/benchmark/benchmark_codec_jpeg.cc
  • tools/benchmark/benchmark_codec_jxl.cc
  • tools/benchmark/benchmark_xl.cc

258efef9aed348cb3d6ed1cb6da26ad287011de1 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/258efef9aed348cb3d6ed1cb6da26ad287011de1
Authored: 2023-01-10 15:27:48 +0100
Committed: 2023-01-10 20:06:09 +0100

Add an HDR roundtrip test for jpegli.

Files Modified:

  • lib/extras/codec_test.cc
  • testdata

30aaae341da7846e7767563da8bec89f14cb8604 by Luca Versari

https://github.com/libjxl/libjxl/commit/30aaae341da7846e7767563da8bec89f14cb8604
Authored: 2023-01-10 12:17:51 +0100
Committed: 2023-01-10 15:01:41 +0100

Disable fast-lossless code path for LSB-padded input.

Files Modified:

  • lib/jxl/encode.cc

7ed5ca476812eaf9b045b53e9f82d4ffa2912b26 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/7ed5ca476812eaf9b045b53e9f82d4ffa2912b26
Authored: 2023-01-09 19:03:30 +0100
Committed: 2023-01-10 12:26:54 +0100

Reimplement extras::EncodeJpeg using jpegli-static library.

This commit also adds support for YUV420 compression.

Files Added:

  • lib/extras/enc/jpegli.cc

Files Deleted:

  • lib/extras/encode_jpeg.cc

Files Modified:

  • lib/extras/codec_test.cc
  • lib/jpegli.cmake
  • lib/jpegli/dct.cc
  • lib/jpegli/dct.h
  • lib/jpegli/encode.cc
  • lib/jpegli/encode.h
  • lib/jpegli/encode_api_test.cc
  • lib/jpegli/encode_internal.h
  • lib/jxl/base/byte_order.h
  • lib/jxl/enc_external_image.cc
  • lib/jxl/test_utils.h
  • lib/jxl_extras.cmake
  • tools/benchmark/benchmark_codec_jpeg.cc
  • tools/build_cleaner.py
  • tools/cjpeg_hdr.cc

Files Changed:

  • R072 lib/extras/encode_jpeg.h

f40514636bf3effc8f9eddc12543a6738a8d0d98 by Luca Versari

https://github.com/libjxl/libjxl/commit/f40514636bf3effc8f9eddc12543a6738a8d0d98
Authored: 2023-01-10 00:31:55 +0100
Committed: 2023-01-10 00:31:55 +0100

Add an explicit flag to allow effort 10. (#2041)

tools/cjxl 211207159-817bc091-3110-48a1-ab60-63c8424e36e1.png -d 0 -e 10 x.jxl
JPEG XL encoder v0.8.0 31e38dae [AVX3,AVX2,SSE4,SSSE3,Unknown]
Invalid flag value for --effort: Valid range is {1, 2, ..., 9}.

tools/cjxl 211207159-817bc091-3110-48a1-ab60-63c8424e36e1.png -d 0 -e 10 x.jxl --allow_expert_options
JPEG XL encoder v0.8.0 31e38dae [AVX3,AVX2,SSE4,SSSE3,Unknown]
./lib/extras/dec/color_hints.cc:54: No color_space/icc_pathname given, assuming sRGB
Read 451x384 image, 1137 bytes, 145.2 MP/s
Encoding [Modular, lossless, effort: 10],
Compressed to 251 bytes (0.012 bpp).
451 x 384, 0.02 MP/s [0.02, 0.02], 1 reps, 72 threads.

tools/cjxl 211207159-817bc091-3110-48a1-ab60-63c8424e36e1.png -d 0 -e 11 x.jxl --allow_expert_options
JPEG XL encoder v0.8.0 31e38dae [AVX3,AVX2,SSE4,SSSE3,Unknown]
Invalid flag value for --effort: Valid range is {1, 2, ..., 10}.

Files Modified:

  • CHANGELOG.md
  • lib/extras/enc/jxl.cc
  • lib/extras/enc/jxl.h
  • lib/include/jxl/encode.h
  • lib/jxl/encode.cc
  • lib/jxl/encode_internal.h
  • tools/cjxl_main.cc

cadf798c1bb57a41c53cd371cec11aa76d0e0179 by Sami Boukortt

https://github.com/libjxl/libjxl/commit/cadf798c1bb57a41c53cd371cec11aa76d0e0179
Authored: 2023-01-09 17:30:07 +0100
Committed: 2023-01-09 18:45:23 +0100

Relax jxl_test slightly

Files Modified:

  • lib/jxl/jxl_test.cc

0442f8e8b9cbf4493626110804636c014269284c by Luca Versari

https://github.com/libjxl/libjxl/commit/0442f8e8b9cbf4493626110804636c014269284c
Authored: 2023-01-09 15:52:28 +0100
Committed: 2023-01-09 16:42:47 +0100

Fix RLE in fast-lossless.

Some bit concatenation was happening with 32 bits instead of 64.

Fixes #2039

Files Modified:

  • lib/jxl/enc_fast_lossless.cc

./mach vendor media/libjxl/moz.yaml reported an error editing moz.build files:

Latest commit is 27f0ffaf77ca9d08222bb17406483ae4509de4dd from 2023-01-13T06:02:06Z
Fetching code archive from https://github.com/libjxl/libjxl/archive/27f0ffaf77ca9d08222bb17406483ae4509de4dd.tar.gz
Retaining wanted in-tree files.
Cleaning third_party/jpeg-xl to import changes.
Unpacking upstream files for third_party/jpeg-xl.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: ['/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/DecoderJni.java', '/tmp/tmpg3denfae/tools/demo_progressive_saliency_encoding.py', '/tmp/tmpg3denfae/.github/workflows/pull_request.yml', '/tmp/tmpg3denfae/tools/djxl_fuzzer.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/ssimulacra.sh', '/tmp/tmpg3denfae/tools/hdr/README.md', '/tmp/tmpg3denfae/tools/optimizer/simplex_fork.py', '/tmp/tmpg3denfae/doc/man/djxl.txt', '/tmp/tmpg3denfae/tools/benchmark/benchmark_file_io.h', '/tmp/tmpg3denfae/tools/box/CMakeLists.txt', '/tmp/tmpg3denfae/tools/benchmark/benchmark_file_io.cc', '/tmp/tmpg3denfae/tools/flicker_test/parameters.cc', '/tmp/tmpg3denfae/tools/benchmark/benchmark_args.cc', '/tmp/tmpg3denfae/tools/cjxl_bisect_bpp', '/tmp/tmpg3denfae/tools/file_io.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/hdrvdp.sh', '/tmp/tmpg3denfae/.github/workflows/build_test.yml', '/tmp/tmpg3denfae/tools/comparison_viewer/settings.h', '/tmp/tmpg3denfae/tools/icc_detect/icc_detect.h', '/tmp/tmpg3denfae/tools/benchmark/metrics/iqa_wrapper.sh', '/tmp/tmpg3denfae/tools/git_version.cmake', '/tmp/tmpg3denfae/tools/wasm_demo/netlify/edge-functions/precompressed.ts', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/StreamInfo.java', '/tmp/tmpg3denfae/doc/color_management.md', '/tmp/tmpg3denfae/tools/wasm_demo/no_png.cc', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_jpeg.h', '/tmp/tmpg3denfae/tools/viewer/viewer_window.h', '/tmp/tmpg3denfae/tools/icc_detect/icc_detect_win32.cc', '/tmp/tmpg3denfae/tools/xyb_range.cc', '/tmp/tmpg3denfae/tools/rans_fuzzer.cc', '/tmp/tmpg3denfae/tools/tool_version.cc', '/tmp/tmpg3denfae/.github/workflows/build_test_cross.yml', '/tmp/tmpg3denfae/.gitignore', '/tmp/tmpg3denfae/tools/benchmark/benchmark_args.h', '/tmp/tmpg3denfae/doc/tables/freq_context.md', '/tmp/tmpg3denfae/tools/box/box.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/vif-rgb.sh', '/tmp/tmpg3denfae/doc/sphinx/api_encoder.rst', '/tmp/tmpg3denfae/tools/benchmark/metrics/run_all_hdr_metrics.sh', '/tmp/tmpg3denfae/tools/wasm_demo/README.md', '/tmp/tmpg3denfae/doc/tables/context_modes.md', '/tmp/tmpg3denfae/.github/workflows/debug_ci.yml', '/tmp/tmpg3denfae/tools/tool_version.h', '/tmp/tmpg3denfae/tools/wasm_demo/one_line_demo.html', '/tmp/tmpg3denfae/tools/benchmark/metrics/mrse.sh', '/tmp/tmpg3denfae/tools/benchmark/metrics/gmsd-rgb.sh', '/tmp/tmpg3denfae/tools/benchmark/metrics/compute_octave_metric.sh', '/tmp/tmpg3denfae/doc/format_overview.md', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_jxl.h', '/tmp/tmpg3denfae/tools/flicker_test/split_view.cc', '/tmp/tmpg3denfae/doc/fuzzing.md', '/tmp/tmpg3denfae/tools/benchmark/metrics/ssim-rgb.sh', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/decoder_jni.cc', '/tmp/tmpg3denfae/doc/tables/app0.md', '/tmp/tmpg3denfae/doc/release.md', '/tmp/tmpg3denfae/doc/sphinx/api_butteraugli.rst', '/tmp/tmpg3denfae/doc/sphinx/api_decoder.rst', '/tmp/tmpg3denfae/doc/vuln_playbook.md', '/tmp/tmpg3denfae/tools/codec_config.cc', '/tmp/tmpg3denfae/tools/README.cjpeg_hdr.md', '/tmp/tmpg3denfae/doc/software_support.md', '/tmp/tmpg3denfae/tools/cjpeg_hdr.cc', '/tmp/tmpg3denfae/tools/wasm_demo/no_png.h', '/tmp/tmpg3denfae/tools/comparison_viewer/compare_images.cc', '/tmp/tmpg3denfae/tools/benchmark/hm/README.md', '/tmp/tmpg3denfae/doc/tables/quant.md', '/tmp/tmpg3denfae/tools/benchmark/metrics/fsim-rgb.sh', '/tmp/tmpg3denfae/tools/hdr/tone_map.cc', '/tmp/tmpg3denfae/tools/conformance/CMakeLists.txt', '/tmp/tmpg3denfae/tools/progressive_sizes.sh', '/tmp/tmpg3denfae/tools/benchmark/metrics/pussim.sh', '/tmp/tmpg3denfae/tools/decode_basic_info_fuzzer.cc', '/tmp/tmpg3denfae/doc/tables/ducky.md', '/tmp/tmpg3denfae/doc/developing_with_crossroad.md', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec.cc', '/tmp/tmpg3denfae/tools/comparison_viewer/image_loading.h', '/tmp/tmpg3denfae/doc/sphinx/conf.py', '/tmp/tmpg3denfae/doc/tables/stock_quant.md', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_avif.h', '/tmp/tmpg3denfae/tools/comparison_viewer/codec_comparison_window.h', '/tmp/tmpg3denfae/tools/benchmark/hm/encode.sh', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_custom.h', '/tmp/tmpg3denfae/doc/tables/all_tables.pdf', '/tmp/tmpg3denfae/tools/benchmark/metrics/msssim-rgb.sh', '/tmp/tmpg3denfae/tools/wasm_demo/jxl_decoder.h', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_webp.h', '/tmp/tmpg3denfae/doc/sphinx/api_common.rst', '/tmp/tmpg3denfae/tools/comparison_viewer/split_image_renderer.cc', '/tmp/tmpg3denfae/tools/djxl_main.cc', '/tmp/tmpg3denfae/doc/tables/nonzero_buckets.md', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_webp.cc', '/tmp/tmpg3denfae/tools/hdr/texture_to_cube.cc', '/tmp/tmpg3denfae/tools/wasm_demo/client_worker.js', '/tmp/tmpg3denfae/tools/viewer/viewer_window.cc', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/Decoder.java', '/tmp/tmpg3denfae/doc/tables/num_nonzero_context.md', '/tmp/tmpg3denfae/doc/developing_in_github.md', '/tmp/tmpg3denfae/tools/benchmark/metrics/compute-hdrvdp.m', '/tmp/tmpg3denfae/tools/progressive_saliency.conf', '/tmp/tmpg3denfae/tools/flicker_test/CMakeLists.txt', '/tmp/tmpg3denfae/.github/ISSUE_TEMPLATE/bug_report.md', '/tmp/tmpg3denfae/tools/wasm_demo/jxl_decompressor.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/dists-rgb.sh', '/tmp/tmpg3denfae/doc/benchmarking.md', '/tmp/tmpg3denfae/tools/cjxl_bisect_size', '/tmp/tmpg3denfae/tools/build_stats.py', '/tmp/tmpg3denfae/tools/benchmark/benchmark_stats.h', '/tmp/tmpg3denfae/tools/flicker_test/setup.ui', '/tmp/tmpg3denfae/tools/ssimulacra2_main.cc', '/tmp/tmpg3denfae/tools/viewer/load_jxl.h', '/tmp/tmpg3denfae/tools/comparison_viewer/CMakeLists.txt', '/tmp/tmpg3denfae/tools/roundtrip_test.sh', '/tmp/tmpg3denfae/tools/flicker_test/setup.h', '/tmp/tmpg3denfae/doc/man/cjxl.txt', '/tmp/tmpg3denfae/tools/wasm_demo/one_line_demo_with_console.html', '/tmp/tmpg3denfae/tools/color_encoding_fuzzer.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/sdr_plots.sh', '/tmp/tmpg3denfae/tools/fields_fuzzer.cc', '/tmp/tmpg3denfae/tools/viewer/main.cc', '/tmp/tmpg3denfae/tools/wasm_demo/service_worker.js', '/tmp/tmpg3denfae/tools/flicker_test/main.cc', '/tmp/tmpg3denfae/tools/cjxl_main.cc', '/tmp/tmpg3denfae/tools/flicker_test/test_window.cc', '/tmp/tmpg3denfae/tools/flicker_test/test_window.h', '/tmp/tmpg3denfae/tools/speed_stats.h', '/tmp/tmpg3denfae/tools/comparison_viewer/split_image_view.h', '/tmp/tmpg3denfae/tools/hdr/display_to_hlg.cc', '/tmp/tmpg3denfae/doc/building_wasm.md', '/tmp/tmpg3denfae/tools/flicker_test/test_window.ui', '/tmp/tmpg3denfae/tools/ssimulacra.cc', '/tmp/tmpg3denfae/tools/args.h', '/tmp/tmpg3denfae/tools/conformance/conformance.py', '/tmp/tmpg3denfae/.github/ISSUE_TEMPLATE/feature_request.md', '/tmp/tmpg3denfae/doc/sphinx/requirements.txt', '/tmp/tmpg3denfae/tools/wasm_demo/manual_decode_demo.html', '/tmp/tmpg3denfae/doc/tables/adobe.md', '/tmp/tmpg3denfae/doc/xl_overview.md', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_avif.cc', '/tmp/tmpg3denfae/doc/tables/markdown-pdf.css', '/tmp/tmpg3denfae/tools/box/box_list_main.cc', '/tmp/tmpg3denfae/doc/tables/all_tables.sh', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/decoder_jni.h', '/tmp/tmpg3denfae/tools/ssimulacra.h', '/tmp/tmpg3denfae/doc/tables/stock_counts.md', '/tmp/tmpg3denfae/doc/tables/symbol_order.md', '/tmp/tmpg3denfae/tools/benchmark/metrics/pupsnr.sh', '/tmp/tmpg3denfae/tools/viewer/CMakeLists.txt', '/tmp/tmpg3denfae/tools/ssimulacra.txt', '/tmp/tmpg3denfae/tools/cjxl_fuzzer.cc', '/tmp/tmpg3denfae/.github/workflows/conformance.yml', '/tmp/tmpg3denfae/tools/ssimulacra2.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/nlpd-y.sh', '/tmp/tmpg3denfae/tools/benchmark/metrics/run_all_sdr_metrics.sh', '/tmp/tmpg3denfae/tools/build_cleaner.py', '/tmp/tmpg3denfae/tools/hdr/pq_to_hlg.cc', '/tmp/tmpg3denfae/tools/comparison_viewer/codec_comparison_window.ui', '/tmp/tmpg3denfae/tools/viewer/load_jxl.cc', '/tmp/tmpg3denfae/doc/tables/icc.md', '/tmp/tmpg3denfae/tools/hdr/exr_to_pq.cc', '/tmp/tmpg3denfae/tools/file_io.h', '/tmp/tmpg3denfae/tools/benchmark/hm/decode.sh', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_png.h', '/tmp/tmpg3denfae/tools/conformance/lcms2.py', '/tmp/tmpg3denfae/.github/workflows/fuzz.yml', '/tmp/tmpg3denfae/tools/hdr/render_hlg.cc', '/tmp/tmpg3denfae/tools/hdr/generate_lut_template.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/prepare_metrics.sh', '/tmp/tmpg3denfae/tools/bisector', '/tmp/tmpg3denfae/tools/fuzzer_stub.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/fsim-y.sh', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/PixelFormat.java', '/tmp/tmpg3denfae/tools/libjxl_test.c', '/tmp/tmpg3denfae/tools/comparison_viewer/codec_comparison_window.cc', '/tmp/tmpg3denfae/tools/comparison_viewer/split_image_view.cc', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/ImageData.java', '/tmp/tmpg3denfae/tools/benchmark/metrics/hdrvdp-fixes.patch', '/tmp/tmpg3denfae/doc/developing_in_windows_vcpkg.md', '/tmp/tmpg3denfae/tools/wasm_demo/CMakeLists.txt', '/tmp/tmpg3denfae/tools/check_author.py', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_png.cc', '/tmp/tmpg3denfae/tools/icc_detect/icc_detect_x11.cc', '/tmp/tmpg3denfae/tools/upscaling_coefficients/upscaler_demo.py', '/tmp/tmpg3denfae/tools/cmdline.h', '/tmp/tmpg3denfae/doc/building_and_testing.md', '/tmp/tmpg3denfae/tools/butteraugli_main.cc', '/tmp/tmpg3denfae/tools/conformance/generator.py', '/tmp/tmpg3denfae/tools/set_from_bytes_fuzzer.cc', '/tmp/tmpg3denfae/tools/conformance/tooling_test.sh', '/tmp/tmpg3denfae/tools/benchmark/metrics/ssim-y.sh', '/tmp/tmpg3denfae/doc/developing_in_windows_msys.md', '/tmp/tmpg3denfae/tools/benchmark/benchmark_xl.cc', '/tmp/tmpg3denfae/tools/wasm_demo/netlify.toml', '/tmp/tmpg3denfae/tools/benchmark/metrics/vsi-rgb.sh', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/decoder_jni_onload.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/compute-pumetrics.m', '/tmp/tmpg3denfae/tools/reference_zip.sh', '/tmp/tmpg3denfae/tools/wasm_demo/jxl_decoder_test.js', '/tmp/tmpg3denfae/tools/benchmark/benchmark_utils.h', '/tmp/tmpg3denfae/tools/benchmark/metrics/hdr_plots.sh', '/tmp/tmpg3denfae/tools/benchmark/metrics/msssim-y.sh', '/tmp/tmpg3denfae/tools/djxl_fuzzer_test.cc', '/tmp/tmpg3denfae/tools/flicker_test/parameters.h', '/tmp/tmpg3denfae/tools/comparison_viewer/split_image_renderer.h', '/tmp/tmpg3denfae/tools/ossfuzz-build.sh', '/tmp/tmpg3denfae/doc/developing_in_debian.md', '/tmp/tmpg3denfae/doc/developing_in_docker.md', '/tmp/tmpg3denfae/doc/sphinx/api.rst', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_custom.cc', '/tmp/tmpg3denfae/doc/sphinx/api_threads.rst', '/tmp/tmpg3denfae/doc/api.txt', '/tmp/tmpg3denfae/.gitmodules', '/tmp/tmpg3denfae/doc/tables/brn_proto.md', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/Status.java', '/tmp/tmpg3denfae/tools/upscaling_coefficients/generate_upscaling_coefficients.py', '/tmp/tmpg3denfae/doc/tables/is_zero_base.md', '/tmp/tmpg3denfae/tools/icc_detect/icc_detect_empty.cc', '/tmp/tmpg3denfae/tools/speed_stats.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/plots.py', '/tmp/tmpg3denfae/tools/benchmark/metrics/iqa.py', '/tmp/tmpg3denfae/tools/box/box.h', '/tmp/tmpg3denfae/tools/jni/org/jpeg/jpegxl/wrapper/DecoderTest.java', '/tmp/tmpg3denfae/tools/cmdline.cc', '/tmp/tmpg3denfae/tools/comparison_viewer/compare_codecs.cc', '/tmp/tmpg3denfae/tools/flicker_test/setup.cc', '/tmp/tmpg3denfae/tools/wasm_demo/jxl_decoder.cc', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_jpeg.cc', '/tmp/tmpg3denfae/tools/comparison_viewer/settings.ui', '/tmp/tmpg3denfae/tools/ssimulacra_main.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/lpips-rgb.sh', '/tmp/tmpg3denfae/doc/jxl.svg', '/tmp/tmpg3denfae/tools/icc_codec_fuzzer.cc', '/tmp/tmpg3denfae/tools/comparison_viewer/settings.cc', '/tmp/tmpg3denfae/tools/benchmark/benchmark_utils.cc', '/tmp/tmpg3denfae/tools/box/box_test.cc', '/tmp/tmpg3denfae/doc/tables/dct_gen.md', '/tmp/tmpg3denfae/tools/comparison_viewer/image_loading.cc', '/tmp/tmpg3denfae/tools/jxlinfo.c', '/tmp/tmpg3denfae/.github/workflows/release.yaml', '/tmp/tmpg3denfae/tools/wasm_demo/jxl_decompressor.h', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec.h', '/tmp/tmpg3denfae/tools/codec_config.h', '/tmp/tmpg3denfae/tools/demo_vardct_select.sh', '/tmp/tmpg3denfae/tools/example_tree.txt', '/tmp/tmpg3denfae/doc/tables/stock_values.md', '/tmp/tmpg3denfae/tools/flicker_test/split_view.h', '/tmp/tmpg3denfae/tools/ssimulacra2.h', '/tmp/tmpg3denfae/tools/comparison_viewer/split_image_view.ui', '/tmp/tmpg3denfae/tools/transforms_fuzzer.cc', '/tmp/tmpg3denfae/tools/fuzzer_corpus.cc', '/tmp/tmpg3denfae/tools/benchmark/metrics/vmaf.sh', '/tmp/tmpg3denfae/tools/decode_and_encode.cc', '/tmp/tmpg3denfae/tools/CMakeLists.txt', '/tmp/tmpg3denfae/tools/benchmark/benchmark_stats.cc', '/tmp/tmpg3denfae/doc/tables/num_nonzeros_base.md', '/tmp/tmpg3denfae/tools/viewer/viewer_window.ui', '/tmp/tmpg3denfae/tools/benchmark/benchmark_codec_jxl.cc', '/tmp/tmpg3denfae/tools/jxl_from_tree.cc', '/tmp/tmpg3denfae/doc/sphinx/index.rst', '/tmp/tmpg3denfae/tools/wasm_demo/build_site.py']
Copying to third_party/jpeg-xl.
Checking for update actions
Registering changes with version control.
Checking for a spurious update.
Version '27f0ffaf77ca9d08222bb17406483ae4509de4dd' has changed 32 files.
Updating moz.yaml.
Found release: 31e38dae584bae991631750ed6a04f1f6323846a (2023-01-09T10:57:58Z).

Found revision: 31e38dae584bae991631750ed6a04f1f6323846a

Updating moz.build files
Found 1 files added and 2 files removed.
Could not add third_party/jpeg-xl/lib/extras/enc/jpegli.cc to the appropriate moz.build file
Could not remove third_party/jpeg-xl/lib/extras/encode_jpeg.cc from the appropriate moz.build file
Could not remove third_party/jpeg-xl/lib/extras/encode_jpeg.h from the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.

We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=192fe7cbbb7a3944475a75218d7bf77fc11f3f1c

All jobs completed, we found the following issues.

Known Issues (From Push Health):

gfx/layers/apz/test/mochitest/browser_test_group_fission.js
	- 1 of 1 failed on the same (retriggered) task
	- test-windows10-64-2004-qr/opt-mochitest-browser-chrome-spi-nw-6 (f_yCsVcTQMuHSUBJkQyBYA)

Needs Investigation (Other Failed Jobs):
test-android-em-7.0-x86_64-qr/debug-isolated-process-geckoview-junit-e10s-single
- 3 of 3 failed on the same (retriggered) task (N4NsTpk3RbiVimXmm41W8g, FUizWAleRYCCKZq_YPorUA, NylWxop2QWGDNzZYblYxsw)
test-android-em-7.0-x86_64-qr/opt-geckoview-junit-e10s-single
- 1 of 1 failed on the same (retriggered) task (YMU9n0rVSTSj5U-zSrTlSw)
test-android-em-7.0-x86_64-qr/debug-geckoview-junit-e10s-single
- 2 of 2 failed on the same (retriggered) task (V_YWtcZ7Rl-8QoMRX7bUWg, MMZgjcQ8RK65Al56XgTjjQ)

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor media/libjxl/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → krosylight
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/351f01ad9a44 Update libjxl to 27f0ffaf77ca9d08222bb17406483ae4509de4dd r=saschanaz

https://hg.mozilla.org/mozilla-central/rev/351f01ad9a44

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox110: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Duplicate of this bug: 1714642
Duplicate of this bug: 1714787
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: