Closed Bug 1810340 Opened 3 years ago Closed 2 years ago

"Inspect" menuitem doesn't work on system pages without a certain uri flag

Categories

(DevTools :: Inspector, defect, P2)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox-esr102 unaffected, firefox109 wontfix, firefox110 wontfix, firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- wontfix
firefox110 --- wontfix
firefox111 --- fixed

People

(Reporter: aminomancer, Assigned: jdescottes)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1810340 - [devtools] Do not load DOMContentReference in the dedicated devtools global
48 bytes, text/x-phabricator-request
Details | Review

STR

  1. Go to about:preferences
  2. Right click something
  3. Click "Inspect"

Expected

Toolbox opens, element is selected after Inspector loads

Actual

Toolbox opens, <body> is selected after Inspector loads (not the element clicked)

Regression range

Discussion

This issue does not affect all system pages. In my very limited testing, the difference between the system pages on which the menuitem works and those on which it does not work seems to be the URI flag nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT. Basically, I went through the about modules one by one and noted which ones work. I might have missed something since I wasn't writing down the results, but it seemed to me that all the working pages have that flag.

Flags: needinfo?(jdescottes)

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Inspector
Component: Inspector → General

Set release status flags based on info from the regressing bug 1796582

status-firefox109: --- → affected
status-firefox110: --- → affected
status-firefox111: --- → affected
status-firefox-esr102: --- → unaffected

I can easily reproduce this on my machine (Win10, Nightly & Release)

Hi Honza, can you please triage this bug with priorty and severity.

Flags: needinfo?(odvarko)

I think this should be P2 S3, but let's add it to triage for tomorrow.

Severity: -- → S3
Flags: needinfo?(odvarko)
Flags: needinfo?(jdescottes)
Priority: -- → P2
Whiteboard: [devtools-triage]
Component: General → Inspector
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Parent process pages use a DevTools server loaded in the devtools global but should still load shared singletons in the regular global.

Whiteboard: [devtools-triage]
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7c65fe094b6 [devtools] Do not load DOMContentReference in the dedicated devtools global r=devtools-reviewers,ochameau

https://hg.mozilla.org/mozilla-central/rev/b7c65fe094b6

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

The patch landed in nightly and beta is affected.
:jdescottes, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(jdescottes)

Regressed in 108, can ride the trains.

status-firefox110: affected → wontfix
Flags: needinfo?(jdescottes)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: