Closed Bug 1810343 Opened 1 year ago Closed 1 year ago

PR_GetPhysicalMemorySize can actually return zero (DragonFly BSD)

Categories

(Core :: Widget: Gtk, defect, P5)

Firefox 108
x86_64
Other
defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: arcade, Assigned: arcade)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; DragonFly x86_64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

Attempted debug build.

Actual results:

When running binary I hit this:

Assertion failure: false (MOZ_ASSERT_UNREACHABLE: PR_GetPhysicalMemorySize not implemented here), at /construction/www/firefox/firefox-108.0.1/image/SurfaceCache.cpp:1625

Expected results:

I think it should work nonetheless, maybe converted to warning?

OS: Unspecified → Other
Hardware: Unspecified → x86_64
Version: Firefox 106 → Firefox 108

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Widget: Gtk
Product: Firefox → Core
Priority: -- → P5

Are you sure this should be phabricated? I'm just rising a question that this ASSERT always fail on my platform, probably memory detection should be properly fixed instead. The patch is pure illustration to describe how I was able to make build work.

Flags: needinfo?(arcade) → needinfo?(stransky)

(In reply to arcade from comment #4)

Are you sure this should be phabricated? I'm just rising a question that this ASSERT always fail on my platform, probably memory detection should be properly fixed instead. The patch is pure illustration to describe how I was able to make build work.

Any patches for Firefox goes through pabricator so yes, if you want this change that's the way (not sure if we have any check for DragonFly or is that a general BSD issue).

Flags: needinfo?(stransky)

Prevents using DEBUG mode to fix issues.

Assignee: nobody → arcade
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9315367 - Attachment description: Bug 1810343 PR_GetPhysicalMemorySize not implemented on DragonFly BSD r?stransky → Bug 1810343 - skip implementation check of PR_GetPhysicalMemorySize on DragonFly BSD r=stransky
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/5ca64201eaff
skip implementation check of PR_GetPhysicalMemorySize on DragonFly BSD r=stransky
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: