1810343 - PR_GetPhysicalMemorySize can actually return zero (DragonFly BSD)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P5)

Description

[arcade]

Attachment: patch-image_SurfaceCache.cpp

User Agent: Mozilla/5.0 (X11; DragonFly x86_64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

Attempted debug build.

Actual results:

When running binary I hit this:

Assertion failure: false (MOZ_ASSERT_UNREACHABLE: PR_GetPhysicalMemorySize not implemented here), at /construction/www/firefox/firefox-108.0.1/image/SurfaceCache.cpp:1625

Expected results:

I think it should work nonetheless, maybe converted to warning?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Please create a phabricator patch for it:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#firefox-contributors-quick-reference
Thanks.

Comment 4

[arcade]

Are you sure this should be phabricated? I'm just rising a question that this ASSERT always fail on my platform, probably memory detection should be properly fixed instead. The patch is pure illustration to describe how I was able to make build work.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to arcade from comment #4)

Are you sure this should be phabricated? I'm just rising a question that this ASSERT always fail on my platform, probably memory detection should be properly fixed instead. The patch is pure illustration to describe how I was able to make build work.

Any patches for Firefox goes through pabricator so yes, if you want this change that's the way (not sure if we have any check for DragonFly or is that a general BSD issue).

Comment 6

[arcade]

Added to phab:

https://phabricator.services.mozilla.com/D168350

Comment 7

[arcade]

Attachment: Bug 1810343 - skip implementation check of PR_GetPhysicalMemorySize on DragonFly BSD r=stransky

Prevents using DEBUG mode to fix issues.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca64201eaff
skip implementation check of PR_GetPhysicalMemorySize on DragonFly BSD r=stransky

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5ca64201eaff