Closed Bug 1810436 Opened 2 years ago Closed 2 months ago

Stop using UNSAFE_componentWillReceiveProps in devtools/client/shared/components/SearchBoxAutocompletePopup.js

Categories

(DevTools :: General, task)

task

Tracking

(firefox135 fixed)

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: nchevobbe, Assigned: ff2400t)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attachment #9436569 - Attachment description: WIP: Bug 1810436 - Stop using UNSAFE_componentWillReceiveProps in devtools/client/shared/components/SearchBoxAutocompletePopup.js → WIP: Bug 1810436 - Stop using UNSAFE_componentWillReceiveProps in devtools/client/shared/components/SearchBoxAutocompletePopup.js r?#devtools-reviewers
Assignee: nobody → ff2400t
Status: NEW → ASSIGNED
Attachment #9436569 - Attachment description: WIP: Bug 1810436 - Stop using UNSAFE_componentWillReceiveProps in devtools/client/shared/components/SearchBoxAutocompletePopup.js r?#devtools-reviewers → Bug 1810436 - Stop using UNSAFE_componentWillReceiveProps in devtools/client/shared/components/SearchBoxAutocompletePopup.js r?#devtools-reviewers
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b020ef6088c Stop using UNSAFE_componentWillReceiveProps in devtools/client/shared/components/SearchBoxAutocompletePopup.js r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch

Perfherder has detected a devtools performance change from push 0c2bb4ccb656d87e2cd8e2eaf6ab80bfcf4746bd.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
11% damp console.objectexpanded.close.DAMP windows11-64-shippable-qr e10s fission stylo webrender 29.36 -> 32.73
8% damp console.objectexpanded.close.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 51.84 -> 56.02
7% damp console.objectexpanded.close.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 43.20 -> 46.12

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42848

For more information on performance sheriffing please see our FAQ.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: