Closed Bug 181047 Opened 23 years ago Closed 23 years ago

Change non-output templates to have a ctype of "none"

Categories

(Bugzilla :: Bugzilla-General, defect, P2)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
2.17
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file, 1 obsolete file)

Patch v.2
8.41 KB, patch
justdave
: review+
Details | Diff | Splinter Review
Some templates such as field-descs.html.tmpl have no output, and so should not have an html ctype. The ctype should be "none". Gerv
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.18
Seeking approval of the name change, before I go and write the trivial but tedious patch required. Gerv
Flags: approval?
sounds good to me.
Flags: approval?
Attached patch Patch v.1 (obsolete) — — Splinter Review
This does the name change; checking this in would be accompanied by a cvs remove of field-descs.html.tmpl and a cvs add of a copy of it as field-descs.none.tmpl. Gerv
Attachment #109336 - Flags: review?(justdave)
Comment on attachment 109336 [details] [diff] [review] Patch v.1 bbaetz: do you have time to review this? It's quite trivial, and justdave seems busy... Gerv
Attachment #109336 - Flags: review?(bbaetz)
Comment on attachment 109336 [details] [diff] [review] Patch v.1 I guess this is fine, if you include the cvs remove/add. I'm not sure if 'none' is the best name, but I can't explain why, nor can I thikn of a better name r=bbaetz
Attachment #109336 - Flags: review?(bbaetz) → review+
Comment on attachment 109336 [details] [diff] [review] Patch v.1 Actually, you left off report-line and report-pie.png.tmpl from teh changed files.
Attachment #109336 - Flags: review+ → review-
OK, but does that really require a re-review? This patch isn't rocket science. Can't I just fix the problem and check in? Gerv
Yeah, OK. Do a grep + diffstat to make sure there wasn't anything else missed
Attached patch Patch v.2 — — Splinter Review
Patch for approval. Gerv
Attachment #109336 - Attachment is obsolete: true
Flags: approval?
Attachment #109336 - Flags: review?(justdave)
Comment on attachment 110710 [details] [diff] [review] Patch v.2 on behalf of bbaetz, per comment 8
Attachment #110710 - Flags: review+
Flags: approval? → approval+
Is anyone working on the review spam problem? Merely moving that review and approving this bug sent me _six_ mails... Fixed. Gerv
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: