Methods of `nsIEditorMailSupport` should work even if the editor is readonly mode
Categories
(Core :: DOM: Editor, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Addons for Thunderbird may want to update editing emails even while the editor is set to readonly. I think that the readonly flag should work with user interaction. Therefore, HTMLEditor should stop checking IsReadOnly in various sub action handlers.
|
Assignee | |
Comment 1•2 years ago
|
||
The readonly flag of HTMLEditor can be set by chrome script or
Document.execCommand("contentReadOnly"). However, the XPCOM APIs should keep
working to update the editable content. E.g., if focused editor is a single
line text field, the app may want to change the value even if it's not editable
by the users.
Note that this patch does not fix all cases of all APIs because this is not
important for Firefox even though the status can be created by web apps (but
Firefox does not use XPCOM APIs basically, instead using XUL commands and it
should not work with readonly state since it may be kicked by user
interactions, e.g., executing a menu item or a shortcut key).
Therefore, it's enough to work it in current Thunderbird for now.
|
||
Comment 2•2 years ago
|
||
Thanks for your time to work on this, Masayuki, even though it is mostly a Thunderbird request.
|
|
Assignee | |
Comment 3•2 years ago
|
||
No problem. Thunderbird testers are really important testers for the editor module since the mail composer is implemented without cross-browser code.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/9d7bac312272 Make `HTMLEditor` check readonly flag when its public methods are called r=m_kato
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•