1810666 - Verify we cannot end up re-using a content process that was NotifiedImpendingShutdown

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Jens Stutte [:jstutte]]

From bug 1809134 comment 10:

Failure log: Assertion failure: !mIsSignaledImpendingShutdown, at /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1988

Failure log mochitest

it seems we have a logical error in our book-keeping that makes us try to reuse a pre-allocated process that has already received SignalImpendingShutdownToContentJS.

This bug should:

• land the assert separately
• fix the already spotted edge case

It seems we have two options here:

• ensure that we always call MarkAsDead together with SignalImpendingShutdownToContentJS here
• check explicitly if mIsSignaledImpendingShutdown is set inside GetUsedBrowserProcess instead of asserting

For symmetry I'd prefer the first, but I'll need to check for fallout (MarkAsDead does some more things, in particular on Android it directly kills the process).

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1810666 - Add an assertion that we won't try to re-use a content process that already received SignalImpendingShutdownToContentJS. r?smaug

Comment 2

[Jens Stutte [:jstutte]]

Attachment: Bug 1810666 - Prevent processes from being re-used after IsSignaledImpendingShutdown r?smaug

Depends on D166991

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9c352e30973
Add an assertion that we won't try to re-use a content process that already received SignalImpendingShutdownToContentJS. r=smaug
https://hg.mozilla.org/integration/autoland/rev/1e06f09456f7
Prevent processes from being re-used after IsSignaledImpendingShutdown r=smaug

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e9c352e30973
https://hg.mozilla.org/mozilla-central/rev/1e06f09456f7