1810687 - Initial session data items are applied too many times on new modules

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Julian Descottes [:jdescottes]]

Spotted while cleaning up a message handler test for Bug 1806820, we apply initial session data items too many times: https://searchfox.org/mozilla-central/rev/d39a17381a14606032f7b8e82789bf281beb1241/remote/shared/messagehandler/WindowGlobalMessageHandler.sys.mjs#75-96

Here we create 1 promise per session data item, but we still pass all the session data items (plural) to each _applySessionData command. So if we have 3 session data items for the same category, new modules will attempt to "apply" all of them 3 times.

In theory there should be no observable issue for consumers here, because modules should safely ignore redundant session data items, but it's still unnecessary processing.

Note that _applySessionData should still be called once per session data item category, so here what we have to do is to group session data items per category, and then call _applySessionData only once per category.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1810687 - [messagehandler] Group SessionData initial updates by moduleName and category.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a27a9ffc1cef
[messagehandler] Group SessionData initial updates by moduleName and category. r=webdriver-reviewers,jdescottes

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a27a9ffc1cef