1810704 - Add telemetry for collecting Session History in Session Store

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Description

[Andreas Farre [:farre]]

Add a FX_SESSION_RESTORE_COLLECT_SESSION_HISTORY_MS probe in SHistoryListener.collect.

Comment 1

[Andreas Farre [:farre]]

Attachment: data-review-session-restore.txt

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1810704 - Collect telemetry for session history collection time. r=peterv!

Comment 3

[Charlie Humphreys [:charlie] [:jeddai]]

Comment on attachment 9312572 [details]
data-review-session-restore.txt

I think FX_SESSION_RESTORE_COLLECT_SESSION_HISTORY_MS would be better represented as technical data (Cat 1) rather than interaction data (Cat 2).

As long as I'm understanding this correctly, it seems like while the user triggers the session restore, the actual measurement is being conducted against the collection process. Is that correct?

Otherwise this looks good and happy to data-review+ once that's been discussed or adjusted.

Comment 4

[Andreas Farre [:farre]]

Sure, I'll adjust.

Comment 5

[Andreas Farre [:farre]]

Attachment: data-review-session-restore.txt

Comment 6

[Andreas Farre [:farre]]

Switched category to 1, as discussed. Makes sense.

Comment 7

[Charlie Humphreys [:charlie] [:jeddai]]

It looks like the attached data-review request still notes it as interaction data instead of technical data, can you take a look and see if that's the case on your end?

Got some feedback from other data stewards, I'm going to ignore the attachment and finish the review!

Comment 8

[Charlie Humphreys [:charlie] [:jeddai]]

Comment on attachment 9312771 [details]
data-review-session-restore.txt

Data Review Form

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, through the Histograms.json file and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, via the data-collection opt-out in Firefox settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Yes, this will be a permanent data collection and will be monitored by Andreas Farre ([e-mail])

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Cat 1 (technical data)

5. Is the data collection request for default-on or default-off?
   Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does the data collection use a third-party collection tool? If yes, escalate to legal.
   No

Result

data-review+

Comment 9

[Andreas Farre [:farre]]

Attachment: data-review-session-restore-actual.txt

Yeah, I juggled versions of the file and picked the wrong one. Here's the correct one that reflects the actual change. Thanks.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e344cb12c391
Collect telemetry for session history collection time. r=peterv

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e344cb12c391

Comment 12

[Andreas Farre [:farre]]

Comment on attachment 9312616 [details]
Bug 1810704 - Collect telemetry for session history collection time. r=peterv!

Beta/Release Uplift Approval Request

• User impact if declined: We're trying to optimize principal serialization/deserialization in bug Bug 1795312, and we need to be able to tell if it is successful. Without beta uplift we'll know less.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change with well understood code paths.
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9312616 [details]
Bug 1810704 - Collect telemetry for session history collection time. r=peterv!

Approved for 110 beta 4, thanks.

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/cee557dfe652