1810718 - "Addon:Install" should support installing an add-on that is enabled in Private Browsing mode

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now the Addon:Install command only supports a single flag which is for a temporary installation. It would be helpful to also have an eg. allowPrivateBrowsing flag which would set the right permissions to let the add-on also run in private browsing windows.

Therefore some additional permissions have to be set after the addon has been installed and it's id is known. This could look like:

+    const perms = {
+      permissions: ["internal:privateBrowsingAllowed"],
+      origins: [],
+    };
+    await lazy.ExtensionPermissions.add(id, perms);
+    let addon = await lazy.AddonManager.getAddonByID(id)
+    await addon.reload();

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The product has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1810718 - Add support for installing an add-on that is enabled in Private Browsing mode.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1810718 - Add tests for installing an add-on that is enabled in Private Browsing mode.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e79185b638b2
Add support for installing an add-on that is enabled in Private Browsing mode. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/bb2abec6a56b
Add tests for installing an add-on that is enabled in Private Browsing mode. r=webdriver-reviewers,whimboo

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e79185b638b2
https://hg.mozilla.org/mozilla-central/rev/bb2abec6a56b