1810750 - Implement reorienting of individual print sheets for @page `size` when pages-per-sheet==1

Status: RESOLVED DUPLICATE of bug 1833244

(Core :: Printing: Setup, defect, P3)

Description

[Jonathan Watt [:jwatt]]

Currently our implementaion always rotates the page(s) contained in a sheet for '@page { size: landscape }'.

I don't think it really make sense for page-orientation to exist if we don't rotate the page rather than the sheet for @page { size: landscape} for the common case where pages-per-sheet is 1. The main reason for page-orientation to exist is to rotate sheets that were laid out using the orientation that isn't the default back to the default orientation. (This is particularly useful for PDF output.)

Comment 1

[Emily McDonough [:alaskanemily]]

I believe the purpose of page-orientation is to allow for mixed orientation pages in a document, yes. For a single-page document it does seem like we could just use size: landscape, but I believe that rotation with page-orientation also implies the document is laid out orthogonal to the paper (as in, the actual text/images/etc are rotated in the document when it is sent to print), right? So we kind of always have to use respect it in that way, don't we?

Comment 2

[Jonathan Watt [:jwatt]]

I'm going to come back to this bug and your questions later, but...

I realised in the course of doing more GSuite docs tests that Gsuite doesn't actually use sheet rotation in the print document (contrary to what you see in kiosk mode), even for one page-per-sheet. Even though Chrome supports both sheet and page orientation, Gsuite just uses page rotation. I had thought that we needed a "full" implementation, which explains why my thinking hasn't quite aligned with yours.

The good news is that that makes implementing the parts of page-orientation that GSuite requires much simpler, and my thought that our current size: portrait/landscape implementation needed to be extended isn't necessary for GSuite.

Anyway, let me get the page parts of page-orientation up for review and then I can think further about this bug.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: WIP: Bug 1810750 p1. Implement reorienting of individual print sheets for @page `size` when pages-per-sheet==1

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: WIP: Bug 1810750 p2. Make more code get the sheet size from their actual sheet.

Depends on D178439

Comment 5

[Jonathan Watt [:jwatt]]

I fixed this in bug 1833244.