Closed Bug 1810962 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38031 - Remove duplicated restore calls

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38031 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38031
Details from upstream follow.

Makoto Kato <m_kato@ga2.so-net.ne.jp> wrote:

Remove duplicated restore calls

Calling window_state_context() sets that restore() is added as cleanup function. So it is unnecessary to set restore() as cleanup function again.

Also, until minimize() is called, rect is null, so this test will call set_window_rect() with null parameter. It doesn't support on Gecko [*1].

*1 https://searchfox.org/mozilla-central/rev/9563aef5a0aeaedc73f363172a93b2f10e289c2e/testing/marionette/client/marionette_driver/marionette.py#1358-1375

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 5 subtests

Status Summary

Firefox

OK : 8
PASS : 11[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] 12[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 22[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
FAIL : 7[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 21[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 23[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub]
TIMEOUT: 3[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] 5[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 6[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
ERROR : 2[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 3[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 4[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub]
NOTRUN : 1

Chrome

OK : 7
PASS : 12
FAIL : 21
TIMEOUT: 5
ERROR : 4
NOTRUN : 1

Safari

OK : 5
PASS : 10
FAIL : 24
TIMEOUT: 2
ERROR : 7
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /screen-orientation/active-lock.html [wpt.fyi]: ERROR [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: ERROR, Safari: ERROR)
    • Performing a fragment navigation must not abort the screen orientation change: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • Performing a fragment navigation within an iframe must not abort the lock promise: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
    • Unloading an iframe by navigating it must abort the lock promise: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • /screen-orientation/event-before-promise.html [wpt.fyi]
    • The 'change' event must fire before the [[orientationPendingPromise]] is resolved.: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/fullscreen-interactions.html [wpt.fyi]: ERROR [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: ERROR, Safari: ERROR)
    • Fully unlocking the screen orientation causes a pending lock to be aborted: FAIL (Chrome: FAIL, Safari: FAIL)
    • Fully unlocking the screen orientation causes a pending lock in a nested browsing context to be aborted: FAIL (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/hidden_document.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: OK, Safari: OK)
    • hidden documents must reject went trying to call unlock: FAIL (Chrome: FAIL, Safari: PASS)
    • hidden documents must not unlock the screen orientation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Once maximized, a minimized window can lock or unlock the screen orientation again: FAIL (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/lock-basic.html [wpt.fyi]
    • Test that screen.orientation.lock returns a promise which will be fulfilled with a void value.: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • Test that screen.orientation.lock() is actually async: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/lock-sandboxed-iframe.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
    • Test with 'allow-orientation-lock' sandboxing directive: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/lock-unlock-check.html [wpt.fyi]
    • Re-locking the screen orientation after a change event fires must not abort: FAIL (Chrome: FAIL, Safari: FAIL)
    • Unlocking the screen orientation after a change event must not abort: FAIL (Chrome: FAIL, Safari: TIMEOUT)
  • /screen-orientation/nested-documents.html [wpt.fyi]: ERROR [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: ERROR, Safari: ERROR)
    • Requesting orientation lock from one document cancels the lock request from another document: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • The orientation lock from one document affects lock requests from other documents: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/non-fully-active.html [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: TIMEOUT, Safari: OK)
    • Attempting to lock non-fully active documents results in a InvalidStateError: FAIL (Chrome: PASS, Safari: PASS)
    • Attempting to unlock non-fully active documents results in a InvalidStateError: FAIL (Chrome: FAIL, Safari: PASS)
    • Making a document non-fully active while locking results in an AbortError: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: TIMEOUT, Safari: PASS)
  • /screen-orientation/onchange-event-subframe.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: ERROR)
    • Test subframes receive orientation change events: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • Check directly that events are fired in right order (from top to bottom): TIMEOUT (Chrome: TIMEOUT, Safari: NOTRUN)
  • /screen-orientation/onchange-event.html [wpt.fyi]
    • Test that orientationchange event is not fired when the orientation does not change.: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • Test that orientationchange event is fired when the orientation changes.: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: NOTRUN)
  • /screen-orientation/orientation-reading.html [wpt.fyi]
    • Test that screen.orientation values change if the orientation changes: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • /screen-orientation/unlock.html [wpt.fyi]
    • unlock() aborts a pending lock request: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • unlock() aborts a pending lock request across documents: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c62bff07e91 [wpt PR 38031] - Remove duplicated restore calls, a=testonly https://hg.mozilla.org/integration/autoland/rev/070d0a4f0405 [wpt PR 38031] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6c62bff07e91
https://hg.mozilla.org/mozilla-central/rev/070d0a4f0405

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.