1810995 - Rename BrowserTestUtils.loadURI to BrowserTestUtils.loadURIString

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[:Gijs (out for now; he/him)]

In bug 1810141 we discussed making loadURI take an actual URI and using fixupAndLoadURI for strings, to make it clear what is happening.

One annoying thing is that BrowserTestUtils also has a loadURI API with slightly different params (that takes a string).

I think tests should actually use this API with strings (because they're usually hardcoded and forcing individual tests to make URI instances would be bad dev ergonomics) but they should probably actually not use fixup (because the URIs should be harcoded so we should just try to create the URI).

As a first step to make all these distinctions more explicit, and to make it easier to refactor docshell/webnavigation/browsingcontext's loadURI method, let's rename the BTU method. Because this is reliably called on BrowserTestUtils, this is easy to do automatically.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: jscodeshift transformation

Comment 2

[:Gijs (out for now; he/him)]

Attachment: Bug 1810995 - rename BrowserTestUtils' loadURI to loadURIString to more accurately reflect what it does, r?Standard8

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - toolkit/ - r?Standard8

Depends on D167150

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - dom and docshell - r?Standard8

Depends on D167151

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r?Standard8

Depends on D167152

Comment 6

[:Gijs (out for now; he/him)]

Attachment: Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - other directories - r?Standard8

Depends on D167153

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/123292be486e
rename BrowserTestUtils' loadURI to loadURIString to more accurately reflect what it does, r=Standard8
https://hg.mozilla.org/integration/autoland/rev/87e779a95478
update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - toolkit/ - r=Standard8,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/1c487fd7fbe4
update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - dom and docshell - r=Standard8
https://hg.mozilla.org/integration/autoland/rev/b1e3a79aa45f
update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8
https://hg.mozilla.org/integration/autoland/rev/0cc77d71b6b0
update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - other directories - r=Standard8,webdriver-reviewers,whimboo

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/123292be486e
https://hg.mozilla.org/mozilla-central/rev/87e779a95478
https://hg.mozilla.org/mozilla-central/rev/1c487fd7fbe4
https://hg.mozilla.org/mozilla-central/rev/b1e3a79aa45f
https://hg.mozilla.org/mozilla-central/rev/0cc77d71b6b0