1811018 - The Weather result remains displayed in the Zero-prefix panel when the Space key is pressed inside the Address Bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 111.0a1 - Build ID: 20230118095131
• Firefox Beta 110.0b2 - Build ID: 20221122190120
• Firefox Release 109 - Build ID: 20230112150232

[Affected Platforms]:

• Windows 10 x64
• macOS 12.4
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have Firefox 110 Beta 2 build installed and open.
• Have a VPN client connected to a US server (for users located outside the US).

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Open a new tab.
3. Click inside the Address Bar.
4. Make sure a Weather result is displayed (repeat previous steps if not).
5. Press the “Space” key and observe the Zero-prefix panel.

[Expected result]:

• The "Top Pick" tag and the Weather result are no longer displayed in the Zero-prefix panel.

[Actual result]:

• Only the “Top Pick” tag is no longer displayed, while the Weather result is still shown.

[Notes]:

• Here is a screen recording of the issue: link.
• On Firefox Release 109, the old UI of the weather result does not have the "Top Pick" tag. However, when performing the steps to reproduce from above, the weather result appears to be the first result from the "Firefox Suggest" section.

Comment 1

[Drew Willcoxon :adw]

Thanks, the weather suggestion should not be triggered at all by typing spaces.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1811018 - Don't show a weather suggestion when the search string contains spaces.

The weather suggestion shouldn't be shown when the search string contains only
spaces. We should check queryContext.searchString directly instead of the
trimmed search string. I implemented this wrong in D161410.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e5dccd163cd
Don't show a weather suggestion when the search string contains spaces. r=daisuke

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9e5dccd163cd

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this scenario on the latest Firefox Nightly 111.0a1 (Build ID: 20230120093625) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Weather result and the Top Pick tag are no longer displayed when the "Space" key is pressed.
• Updating the expected result and the bug title to reflect the correct behavior.