1811019 - use `all` and `any` Python builtins instead of checking for `None in list` etc

Status: RESOLVED FIXED

(Conduit :: moz-phab, task)

Description

[Connor Sheehan [:sheehan]]

moz-phab has a few usages of un-Pythonic idioms to check for invalid values. For example in this if statement we create a list of all the type keys and then re-iterate over the list to see if "abandon" in list is True. We should be using any with a generator, which is more efficient and easier to understand.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: reorg: use `any` with generator instead of a list (Bug 1811019) r?grammar,zeid

Use any function with a passed generator instead of
building a list and then looking for the value in the
list.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: mercurial: use `any` instead of creating list (Bug 1811019) r?grammar,zeid

Depends on D167176

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: user: use all instead of `None not in list` (Bug 1811019) r?grammar,zeid

Depends on D167177

Comment 4

[Connor Sheehan [:sheehan]]

Attachment: diff: use set instead of list (Bug 1811019) r?grammar,zeid

Sets are faster for __contains__ operations.

Depends on D167178

Comment 5

[Connor Sheehan [:sheehan]]

Attachment: diff: simplify if statement with both branches having same result (Bug 1811019) r?grammar,zeid

Both branches do the same thing, so reduce to the more
generic option to simplify.

Depends on D167179

Comment 6

[Connor Sheehan [:sheehan]]

Attachment: user: de-dent `set_from_file` (Bug 1811019) r?grammar,zeid

Depends on D167180