1811183 - Crash in [@ java.lang.NumberFormatException: at jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java)] for input string "any"

Status: VERIFIED FIXED

(Fenix :: Browser Engine, defect, P2)

Description

[Chris Peterson [:cpeterson]]

@ Roger, this crash looks like a regression in Fenix 106 from the fix for bug 1790425 (https://github.com/mozilla-mobile/android-components/pull/12802). The earliest version with a NumberFormatException: For input string: "any" crash report is 106.0b1 and the fix for bug 1790425 was uplifted to Beta 106.

GeckoPromptDelegate.onDateTimePrompt Bug 1790425's crashes had NumberFormatException: empty String. This bug's crashes have NumberFormatException: For input string: "any".

Crash report: https://crash-stats.mozilla.org/report/index/2e61e0be-bc60-4094-ba84-4527f0230118

Java stack trace:

java.lang.NumberFormatException: For input string: "any"
	at jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2054)
	at jdk.internal.math.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
	at java.lang.Float.parseFloat(Float.java:455)
	at mozilla.components.browser.engine.gecko.prompt.GeckoPromptDelegate.onDateTimePrompt(GeckoPromptDelegate.kt:117)
	at org.mozilla.geckoview.PromptController$DateTimeHandler.callDelegate(PromptController.java:2)
	at org.mozilla.geckoview.PromptController$DateTimeHandler.callDelegate(PromptController.java:1)
	at org.mozilla.geckoview.PromptController.getResponse(PromptController.java:65)
	at org.mozilla.geckoview.PromptController.handleEvent(PromptController.java:50)
	at org.mozilla.geckoview.GeckoSession$Listener.handleMessage(GeckoSession.java:44)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:13)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7872)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Comment 1

[Chris Peterson [:cpeterson]]

Moving from GeckoView to Fenix because this is an A-C bug.

Comment 2

[Roger Yang [:royang]]

Looks like the same crash. Adding Alexandru to confirm if there's a corner case that can still cause a crash.

Comment 3

[Alexandru Putanu [:aputanu]]

Found that any string input set as step is directly passed with the DateTimePrompt. I'll work on a patch to handle this in A-C.

Comment 4

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1811183 - Handle non-digit step values passed for time input (#603)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Landed on main:
https://github.com/mozilla-mobile/firefox-android/commit/92e18c2e8c59798da3ad61bde8e49910a6e9c267

Crash volume on Release doesn't seem high enough to worry about an uplift to 109, but we will probably want to backport this to v110 still given that it's a small fix w/ an automated test.

Comment 6

[Lorand Janos]

Managed to reproduce the crash in earlier builds:

• latest RC 109.1.1.
• latest Beta 110.0b4.
  Verified as fixed on the latest Nightly 111.0a1 (2023-01-27) build by tapping on any item from https://codepen.io/alexp7777/pen/YzavNYg.
  Device used: Oppo Find X5 (Android 12).

Comment 7

[Chris Peterson [:cpeterson]]

Alexandru, do you think your crash fix is safe to uplift to Beta 110?

Comment 8

[Alexandru Putanu [:aputanu]]

I think the fix is small enough and safe to uplift to Beta 110, I'll prepare the uplift.

Comment 9

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1811183 - Handle non-digit step values passed for time input (backport #603) (#654)

Comment 10

[Alexandru Putanu [:aputanu]]

Backported to 110 https://github.com/mozilla-mobile/firefox-android/commit/d57a7c30493cc92aa063e876763587fab3bfa6ac

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Alexandru Putanu [:aputanu] from comment #10)

Backported to 110 https://github.com/mozilla-mobile/firefox-android/commit/d57a7c30493cc92aa063e876763587fab3bfa6ac

FYI, CI is failing on this push

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to Pascal Chevrel:pascalc from comment #11)

(In reply to Alexandru Putanu [:aputanu] from comment #10)

Backported to 110 https://github.com/mozilla-mobile/firefox-android/commit/d57a7c30493cc92aa063e876763587fab3bfa6ac

FYI, CI is failing on this push

Pascal, where can we find the CI error? Should we revert this fix from Beta 110?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

As far as I can tell, it was an intermittent issue. Later commits are green.

Comment 14

[Lorand Janos]

Verified as fixed on the latest Beta 110.0b6 build by tapping on any item from https://codepen.io/alexp7777/pen/YzavNYg.
Device used: Google Pixel 7 (Android 13).
Marking as verified for 110.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20962bbae5f9
Handle non-digit step values passed for time input