1811241 - [Linux] Dragging a tab out of a window always results in "cancel" animation

Status: ASSIGNED

(Core :: Widget: Gtk, defect)

Description

[:Gijs (he/him)]

Spun off from bug 1635761.

I fixed the issue on macOS. The documentation says returning true vs false in the "drag failed" handler should govern this behaviour, but somehow my patch doesn't seem to actually effect any change in behaviour on my Ubuntu VM. I'll attach the patch here in case someone else has time to dig into it further.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1811241 - get Linux to also not show drag cancel animation for tabs dragged out of the window, r?emilio

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

I tested this patch on my Ubuntu machine, it works as expected.

Comment 3

[:Gijs (he/him)]

Attachment: screencast.webm

I rebased the patch and tried again but I still see the animation. Here's a screencast. Are you saying that on your machine, without this patch you see the window thumb making its way back to the old window, and that doesn't happen with the patch applied? I guess I can put it up for review but it feels weird to do that because I can still reproduce the problem... but I suppose that may be due to an older ubuntu version or w/e ?

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Screencast_without_patch.webm

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Screencast_with_patch.webm

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to :Gijs (he/him) from comment #3)

Are you saying that on your machine, without this patch you see the window thumb making its way back to the old window, and that doesn't happen with the patch applied?

Yes, on my machine (Ubuntu 22.04.2 LTS):

• Without this patch I can see the cancel animation (window thumb making its way back to the old window): attachment #9405533 [details].
• And that doesn't occur with the patch applied: attachment #9405534 [details].

Comment 7

[:Gijs (he/him)]

(In reply to Edgar Chen [:edgar] from comment #6)

(In reply to :Gijs (he/him) from comment #3)

Are you saying that on your machine, without this patch you see the window thumb making its way back to the old window, and that doesn't happen with the patch applied?

Yes, on my machine (Ubuntu 22.04.2 LTS):

• Without this patch I can see the cancel animation (window thumb making its way back to the old window): attachment #9405533 [details].
• And that doesn't occur with the patch applied: attachment #9405534 [details].

Huh, OK. I don't know why it doesn't work for me, then. But I guess if it works that's good. The one thing that I'm surprised by in your screencast is that it appears that the time for the window to appear does not appear to decrease - in fact, it takes slightly longer in the "fixed" screencast, but I'm measuring based on crude video timestamping and it looks like it's a debug build so perhaps that's just noise. Still, it's a bit surprising to me.

Anyway, I guess we should try to get this landed, then, and see if there's follow-up work to do / if someone else can figure out why it doesn't work in some circumstances.