1811353 - two width: 50% inline-block elements wrap instead of staying on the same line inside a table (Blink and WebKit ignore whitespace text nodes inside table-internal parts)

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: diff.html

The attached file displays properly in Safari and Chrome.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case

So this is kind of expected because there's whitespace between the two inline-blocks. I'm not sure why Blink / WebKit behave differently with tables...

Comment 2

[Emilio Cobos Álvarez (:emilio)]

It seems blink avoids creating whitespace text nodes in tables unconditionally (here)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Something like this fixes the test-case above:

diff --git a/layout/base/nsCSSFrameConstructor.cpp b/layout/base/nsCSSFrameConstructor.cpp
index 5305b628bd521..9b2226949b261 100644
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -2314,7 +2314,8 @@ static inline bool NeedFrameFor(const nsFrameConstructorState& aState,
   // white-space, where we know we'll be dropping them all anyway, and involve
   // an extra walk down the frame construction item list.
   auto excludesIgnorableWhitespace = [](nsIFrame* aParentFrame) {
-    return aParentFrame->IsFrameOfType(nsIFrame::eXULBox) ||
+    return aParentFrame->IsTableFrame() ||
+           aParentFrame->IsFrameOfType(nsIFrame::eXULBox) ||
            aParentFrame->IsFrameOfType(nsIFrame::eMathML);
   };
   if (!aParentFrame || !excludesIgnorableWhitespace(aParentFrame) ||

But it's unclear to me what in the spec justifies it.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1811353 - Add a test for this WebKit / Blink bug. r=jrmuizel,#layout

See help links and spec issue.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ea945ffd5ee
Add a test for this WebKit / Blink bug. r=jrmuizel

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38192 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9ea945ffd5ee

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot