1811368 - Improve builtin allocation perfomance of GC objects

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Description

[Ryan Hunt [:rhunt]]

The struct/array allocation builtins are doing a lot of work that could be done just once at instantiation and then cached.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1811368 - wasm: Remove unneeded MaxTypeIndex. r?jseward

This used to be required by an old representation of PackedTypeCode, but
is no longer needed.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1811368 - wasm: Compute allocation parameters for types at instantiation. r?jseward

This commit creates an AllocArgs struct which stores the params that
GC object allocation will use. When we instantiate a module, we compute those
parameters for each type up front and store it in the instance data area. The
JIT then will pass a pointer to these parameters when allocating objects.

Depends on D167313

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1811368 - wasm: Make structs with only inline data able to use the nursery. r?jseward

Objects with finalizers cannot use the nursery (except if they opt-in and use some more
complicated logic that we cannot use yet). This commit adds a new class for inline-only
structs that allows them to be allocated in the nursery.

Depends on D167314

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8821bee4d401
wasm: Remove unneeded MaxTypeIndex. r=jseward
https://hg.mozilla.org/integration/autoland/rev/3fc90d1119d6
wasm: Compute allocation parameters for types at instantiation. r=jseward
https://hg.mozilla.org/integration/autoland/rev/5309cb65c435
wasm: Make structs with only inline data able to use the nursery. r=jseward
https://hg.mozilla.org/integration/autoland/rev/dc5abbbf3907
1811368, 1811368: apply code formatting via Lando

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing SM bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=fdIHEKeVR7uHgC6LtCqMfw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=dc5abbbf39078259c6a08c0169a8162264c254e4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=403057657&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/27bc772916c3222b2d9b245fe31f89c15192000a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c7e1877c8f3
wasm: Remove unneeded MaxTypeIndex. r=jseward
https://hg.mozilla.org/integration/autoland/rev/78dd59c068a9
wasm: Compute allocation parameters for types at instantiation. r=jseward
https://hg.mozilla.org/integration/autoland/rev/58bdec1f2dec
wasm: Make structs with only inline data able to use the nursery. r=jseward

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0c7e1877c8f3
https://hg.mozilla.org/mozilla-central/rev/78dd59c068a9
https://hg.mozilla.org/mozilla-central/rev/58bdec1f2dec