1811416 - Fail early if a localized build is attempted with artifact builds enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

The docs for localized builds mention that artifact builds are not supported, but if you miss that note, you will eventually hit this error:

 0:04.24 make[4]: *** No rule to make target `l10n'.  Stop.
 0:04.24 make[3]: *** [l10n-ar] Error 2
 0:04.24 make[2]: *** [l10n-ar] Error 2
 0:04.24 make[1]: *** [langpack-ar] Error 2
 0:04.24 make: *** [langpack-ar] Error 2

Which does not make it obvious that the problem is artifact builds being enabled. We should fail early and inform the user of the problem.

Comment 1

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1811416 - Fail early if a Localized Build is attempted with Artifact Builds enabled r?#build

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ahochheiden, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

I'll land it after the soft code freeze is lifted.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c7577bdd6e3
Fail early if a Localized Build is attempted with Artifact Builds enabled r=firefox-build-system-reviewers,glandium

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9c7577bdd6e3