1811459 - TypeError: can't access property "getAttribute", this.node is null" {file: "resource:///modules/PanelMultiView.jsm" line: 634}

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P1)

Description

[Rob Wu [:robwu]]

Originally encountered in bug 1707305, but plastered over with extra waits. I think that there is an actual issue in PanelMultiView; it looks like the _moveOutKids assumes the panelmultiview to still be instantiated, but in practice it may already have been disconnect()ed before.

Console message: [JavaScript Error: "TypeError: can't access property "getAttribute", this.node is null" {file: "resource:///modules/PanelMultiView.jsm" line: 634}]
INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_incognito_views.js | A promise chain failed to handle a rejection: **can't access property "getAttribute", this.node is null - stack: _moveOutKids@resource:///modules/PanelMultiView.jsm:634:23
INFO - removePopup@resource:///modules/PanelMultiView.jsm:325:24
INFO - panelRemover@chrome://browser/content/customizableui/panelUI.js:471:24
INFO - showSubView@chrome://browser/content/customizableui/panelUI.js:497:9
INFO - async*showWidgetView@resource:///modules/CustomizableUI.jsm:2171:25
INFO - handleWidgetCommand@resource:///modules/CustomizableUI.jsm:2190:12
INFO - openPopup@chrome://browser/content/parent/ext-browserAction.js:523:44
INFO - openPopup@chrome://browser/content/parent/ext-browserAction.js:1004:24
INFO - recvAPICall/result</</<@resource://gre/modules/ExtensionParent.jsm:1155:16

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1811459 - Avoid _moveOutKids on disconnected panelmultiview

this.forNode (with this being a PanelMultiView instance) may
return a node that was already disconnected before, in which case its
node member will be void. To avoid unexpected promise rejections, add
a null check before _moveOutKids().

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1811459 - Avoid _moveOutKids on disconnected panelmultiview

this.forNode (with this being a PanelMultiView instance) may
return a node that was already disconnected before, in which case its
node member will be void. To avoid unexpected promise rejections, add
a null check before _moveOutKids().

Original Revision: https://phabricator.services.mozilla.com/D167369

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a67e337ab7b
Avoid _moveOutKids on disconnected panelmultiview r=Gijs,rpl

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8a67e337ab7b