1811469 - "Request uplift" button creates too many revisions - including revisions not part of the patch stack

Status: RESOLVED FIXED

(Conduit :: Lando, defect)

Description

[Rob Wu [:robwu]]

I had a patch stack of two patches, one with r+ and one without.
I noticed a "Request uplift" button and clicked it because I was wondering what it did: While there is no tooltip to explain what clicking the button does, I eventually intended to use the Bugzilla flags to request uplift anyway, so the button label matches my eventual goals.

Without further confirmation prompts, Lando apparently created two new Phabricator revisions. The first cloned Phabricator revision seems reasonable, but the second one is unexpected. For comparison, when the "Preview Landing" + "Land to integration/autoland" buttons are clicked, only the selected patches in the patch stack are scheduled to land.

Examples:

• Selected patch: https://lando.services.mozilla.com/D167190/
• Second part in stack (not selected): https://phabricator.services.mozilla.com/D167369
• Created clone of selected patch: https://phabricator.services.mozilla.com/D167372
• Unexpected clone of second patch: https://phabricator.services.mozilla.com/D167373

Comment 1

[Connor Sheehan [:sheehan]]

Thanks for trying out the new uplift request button in Lando. This is great feedback, I appreciate the bug report.

If you only selected one revision in the stack, the expected behaviour is to only create one uplift request. I'll look into reproducing this and fixing it.

We should certainly have a tooltip for the button, and having a further confirmation prompt before creating the new revisions seems reasonable as well. I'll create bugs for those suggestions. There is also bug 1801959 which would solve the further confirmation problem by making a proper modal for the button and moving it out of the landing modal.

Comment 2

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] stacks: implement `RevisionStack` with `networkx` (Bug 1811469) (#266)