1811494 - Running Puppeteer tests errors out on Windows with "AttributeError: module 'os' has no attribute 'uname'"

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect)

Description

[Oliver Medhurst [:canadahonk]]

Steps to reproduce:

Run ./mach puppeteer-test on Windows.

Actual results:

After Puppeteer gets ready, the Python command fails with the error:

Running job lib/esm/package.json...
Running job lib/types.d.ts and docs/puppeteer.api.json...
Using extra preference: fission.autostart=True
Traceback (most recent call last):
  File "C:\mozilla-source\mozilla-unified\remote\mach_commands.py", line 659, in puppeteer_test
    return puppeteer.run_test(logger, *tests, **params)
  File "C:\mozilla-source\mozilla-unified\remote\mach_commands.py", line 468, in run_test
    platform = os.uname().sysname.lower() if os.uname() else "win32"
AttributeError: module 'os' has no attribute 'uname'

Expected results:

No errors on running.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for filing the bug! This is a regression from bug 1797723.

Comment 2

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1811494 - Fix running Puppeteer tests on Windows erroring out

Fixed regression which caused a Python error preventing Puppeteer tests
on Windows being ran.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af6674282df0
Fix running Puppeteer tests on Windows erroring out r=webdriver-reviewers,Sasha,jdescottes

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/af6674282df0