1811737 - Move processAssertions before append in ModuleBuilder::appendModuleRequest

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jonatan Klemets [:jon4t4n]]

We need to call processAssertions before we append moduleRequests_ because the append will invoke the StencilModuleRequest copy constructor.
https://searchfox.org/mozilla-central/rev/f4948f24dd3d4ddf557f1d93337f3ab43e8220a7/js/src/builtin/ModuleObject.cpp#2065,2070-2072

This behavior is covered by js/src/jit-test/tests/modules/requested-modules.js but is behind a flag.

Comment 1

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1811737 - Move processAssertions before append in ModuleBuilder::appendModuleRequest r=jonco

We need to call processAssertions before we append moduleRequests_ because
the append will invoke the StencilModuleRequest copy constructor.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1806136

Comment 3

[Jonatan Klemets [:jon4t4n]]

Maybe I shouldn't have marked this as a regression to not kick off a chain reaction... Anyhow, import assertions are behind a flag and JSON modules haven't landed yet, so this can probably be marked as wontfix.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56318716c945
Move processAssertions before append in ModuleBuilder::appendModuleRequest r=jonco

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/56318716c945

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jon4t4n, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Jonatan Klemets [:jon4t4n]]

Matthew, could you set status-firefox110 to wontfix? I don't have the needed permissions. See comment 3 for the why.

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Done. Thanks for the ping!