Event listener checkbox sizes vary
Categories
(DevTools :: Inspector, defect, P3)
Tracking
(relnote-firefox 109+, firefox-esr102 unaffected, firefox109 verified, firefox110 verified, firefox111 verified)
Tracking | Status | |
---|---|---|
relnote-firefox | --- | 109+ |
firefox-esr102 | --- | unaffected |
firefox109 | --- | verified |
firefox110 | --- | verified |
firefox111 | --- | verified |
People
(Reporter: sebo, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
73.31 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-release+
|
Details | Review |
The display of the event listener checkboxes inside the Inspector is broken. The sizes of the checkboxes vary.
Steps to reproduce:
- Open the Inspector on this page
- Click the "event" badge besides the
<html>
tag
⇒ The sizes of the checkboxes differ.
Expected: The sizes of the checkboxes are all the same.
Sebastian
Comment 1•2 years ago
|
||
:sebo, if you think that's a regression, could you try to find a regression range using for example mozregression?
Reporter | ||
Comment 2•2 years ago
|
||
Running mozregression resulted in bug 1791067 being the culprit for this bug.
One possible solution is to make the checkboxes inflexible, e.g. via
.event-tooltip-listener-toggle-checkbox {
flex: none;
}
Sebastian
Comment 3•2 years ago
|
||
Set release status flags based on info from the regressing bug 1791067
:emilio, since you are the author of the regressor, bug 1791067, could you take a look? Also, could you set the severity field?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 4•2 years ago
|
||
Yeah, that or min-width: auto;
which would be a more direct change. It seems surrounding code uses flex-shrink: 0
so I'll do that.
Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
bugherder |
Comment 8•2 years ago
|
||
If you want to nominate this for Beta and Release approval, I'd take it as a ride-along for next week's scheduled dot release.
Assignee | ||
Comment 9•2 years ago
|
||
Comment on attachment 9313684 [details]
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: comment 0
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix.
- String changes made/needed: none
- Is Android affected?: No
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Reproduced the issue with Firefox 111.0a1 (2023-01-22) on Windows 10x64 by following the STR from comment 0. The checkboxes have a different size inside the event drop-down.
The issue is verified fixed with Firefox 111.0a1 (2023-01-26) on Windows 10x64, macOS 11.5 and Ubuntu 20.04. The checkboxes from the event dropdown have the same size.
Comment 11•2 years ago
|
||
Comment on attachment 9313684 [details]
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers
Approved for 110 beta 6, thanks.
Comment 12•2 years ago
|
||
bugherder uplift |
Comment 13•2 years ago
|
||
Verified fixed with Firefox 110.0b6 on Windows 10x64, macOS 11.5, and Ubuntu 20.04. The checkboxes from the event dropdown have the same size.
Comment 14•2 years ago
|
||
Comment on attachment 9313684 [details]
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers
Approved for 109.0.1
Comment 15•2 years ago
|
||
bugherder uplift |
Comment 16•2 years ago
|
||
Added to the 109.0.1 relnotes:
Fixed inconsistent sizing of event listener checkboxes inside the Inspector developer tool
Comment 17•2 years ago
|
||
Verified fixed with Firefox 109.0.1 on Windows 10x64, macOS 12.3 and Ubuntu 18.04. The checkboxes from the event dropdown have the same size.
Description
•