Closed Bug 1811760 Opened 1 year ago Closed 1 year ago

Event listener checkbox sizes vary

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(relnote-firefox 109+, firefox-esr102 unaffected, firefox109 verified, firefox110 verified, firefox111 verified)

Status:
VERIFIED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 109+
firefox-esr102 --- unaffected
firefox109 --- verified
firefox110 --- verified
firefox111 --- verified

People

(Reporter: sebo, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Incorrect display of event listener toggle checkbox.png
73.31 KB, image/png
Details
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release+
Details | Review

The display of the event listener checkboxes inside the Inspector is broken. The sizes of the checkboxes vary.

Steps to reproduce:

  1. Open the Inspector on this page
  2. Click the "event" badge besides the <html> tag

⇒ The sizes of the checkboxes differ.

Expected: The sizes of the checkboxes are all the same.

Sebastian

:sebo, if you think that's a regression, could you try to find a regression range using for example mozregression?

Running mozregression resulted in bug 1791067 being the culprit for this bug.

One possible solution is to make the checkboxes inflexible, e.g. via

.event-tooltip-listener-toggle-checkbox {
  flex: none;
}

Sebastian

Keywords: regression
Regressed by: 1791067

Set release status flags based on info from the regressing bug 1791067

:emilio, since you are the author of the regressor, bug 1791067, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

status-firefox109: --- → affected
status-firefox110: --- → affected
status-firefox111: --- → affected
status-firefox-esr102: --- → unaffected
Flags: needinfo?(emilio)

Yeah, that or min-width: auto; which would be a more direct change. It seems surrounding code uses flex-shrink: 0 so I'll do that.

Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e5c7a92b77d
Don't allow event-listener checkboxes to shrink. r=devtools-reviewers,nchevobbe
Severity: -- → S3
Priority: -- → P3

https://hg.mozilla.org/mozilla-central/rev/3e5c7a92b77d

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

If you want to nominate this for Beta and Release approval, I'd take it as a ride-along for next week's scheduled dot release.

Flags: needinfo?(emilio)

Comment on attachment 9313684 [details]
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: comment 0
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(emilio)
Attachment #9313684 - Flags: approval-mozilla-release?
Attachment #9313684 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced the issue with Firefox 111.0a1 (2023-01-22) on Windows 10x64 by following the STR from comment 0. The checkboxes have a different size inside the event drop-down.
The issue is verified fixed with Firefox 111.0a1 (2023-01-26) on Windows 10x64, macOS 11.5 and Ubuntu 20.04. The checkboxes from the event dropdown have the same size.

status-firefox111: fixed → verified

Comment on attachment 9313684 [details]
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers

Approved for 110 beta 6, thanks.

Attachment #9313684 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed with Firefox 110.0b6 on Windows 10x64, macOS 11.5, and Ubuntu 20.04. The checkboxes from the event dropdown have the same size.

status-firefox110: fixed → verified

Comment on attachment 9313684 [details]
Bug 1811760 - Don't allow event-listener checkboxes to shrink. r=#devtools-reviewers

Approved for 109.0.1

Attachment #9313684 - Flags: approval-mozilla-release? → approval-mozilla-release+

Added to the 109.0.1 relnotes:

Fixed inconsistent sizing of event listener checkboxes inside the Inspector developer tool

relnote-firefox: --- → 109+

Verified fixed with Firefox 109.0.1 on Windows 10x64, macOS 12.3 and Ubuntu 18.04. The checkboxes from the event dropdown have the same size.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox109: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: