1811836 - Look into simplifying RFP check in MediaDevices::OnDeviceChange

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement)

Description

[Tom Schuster (MoCo)]

Right now MediaDevices::OnDeviceChange calls ShouldResistFingerprinting with a justification, but I am wondering if we could change this code now that checking ShouldResistFingerprinting() on windows is fast.

I am a bit hesitant, because the code seems quite complicated. However after we pass the RFP check we set mHaveUnprocessedDeviceListChange and call MaybeResumeDeviceExposure and that function requires GetOwner to return a non-null value. Could we move the RFP check into that function?

Or is mHaveUnprocessedDeviceListChange actually some kind of way of retrying that function when we don't have a window?

Comment 1

[Tom Ritter [:tjr]]

FWIW The efficiency check isn't so much because ShouldRFP is fast, but because there's all that other stuff I wanted to guard. Bug 1721840 had similar code that had showed up in hangstats, so I think I was being similarly conservative.

Comment 2

[Fatih Kilic [:fkilic]]

Attachment: Bug 1811836: Move devicechange rfp check from OnDeviceChange to MaybeResumeDeviceExposure where we always have window. r?tjr

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/827061454ed8
Move devicechange rfp check from OnDeviceChange to MaybeResumeDeviceExposure where we always have window. r=tjr

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/827061454ed8