Closed
Bug 1812030
Opened 1 year ago
Closed 1 year ago
nsCookieInjector does not observe detect-only pref
Categories
(Core :: Privacy: Anti-Tracking, defect, P1)
Core
Privacy: Anti-Tracking
Tracking
()
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox109 | --- | unaffected |
| firefox110 | --- | unaffected |
| firefox111 | --- | fixed |
People
(Reporter: pbz, Assigned: pbz)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
In Bug 1809700 I didn't add an observer for the new (separate) detectOnly pref. We should add one so that the cookie injector can react to pref changes.
https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/toolkit/components/cookiebanners/nsCookieInjector.cpp#40-48
|
||
Updated•1 year ago
|
Keywords: regression
|
|
||
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1809700
status-firefox109:
--- → unaffected
status-firefox110:
--- → unaffected
status-firefox111:
--- → affected
status-firefox-esr102:
--- → unaffected
|
Assignee | |
Comment 2•1 year ago
|
||
- Fix typo in IsEnabledForCurrentPrefState leading to component not enabling if
one of the service modes was set to disabled. - Clean up pref observer code by moving list of prefs to array.
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/115ffcd85a81 Fix pref observers in nsCookieInjector. r=timhuang
|
||
Comment 4•1 year ago
|
||
Backed out for causing bustages in nsCookieInjector.cpp.
- Backout link
- Push with failures
- Failure Log
- Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:675: Unified_cpp_cookiebanners0.obj] Error 1
Flags: needinfo?(pbz)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(pbz)
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1067822de638 Fix pref observers in nsCookieInjector. r=timhuang
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•