1812078 - nsIClipboardOwner isn't tracked correctly on Mac

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Edgar Chen [:edgar]]

There is only one cached nsITransferable and nsIClipboardOwner in nsBaseClipboard to track the ownership of clipboard data, https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/widget/nsBaseClipboard.h#46-47. If we support multiple clipboard type, this cache is shared between them, so setting data to one clipboard type will clear the ownership for another clipboard type, and cause nsIClipboardOwner::LosingOwnership get called.

We don't encounter this issue on Windows as it only supports one clipboard type.

And we also behave correctly on Linux as it doesn't inherit nsBaseClipboard and has separated cache for each clipboard type, https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/widget/gtk/nsClipboard.h#139-144

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1812078 - Part 1: Use passed nsITransferable in SetNativeClipboardData;

Instead of using mTransferable, so that windows widget don't need to access
mTransferable which is used as cache in cocoa widget.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1812078 - Part 1: Have separated clipboard caches for each clipbaord type to track clipboard owner; r?mstange

Depends on D148940

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1812078 - Part 2: Make SelectionCache type behave more generic; r?mstange

Depends on D167997

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8c4caffe6dfcc6007603b84db2ad8cdc68e849a2

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1812078 - Part 1: Have a generic way to initialize clipboard capabilities;

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8c3c6485f27067c0fe31c9445ff09dc13aa6d08a

Comment 7

[Phabricator Automation]

Comment on attachment 9323930 [details]
Bug 1812078 - Part 1: Have a generic way to initialize clipboard capabilities;

Revision D173009 was moved to bug 1834710. Setting attachment 9323930 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/704dc8d1421b
Part 1: Have separated clipboard caches for each clipbaord type to track clipboard owner; r=mstange
https://hg.mozilla.org/integration/autoland/rev/9e25deb0b839
Part 2: Make SelectionCache type behave more generic; r=mstange

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/704dc8d1421b
https://hg.mozilla.org/mozilla-central/rev/9e25deb0b839