181212 - Probable leak in nsAbDirectoryDataSource::createDirectoryChildNode

Status: RESOLVED DUPLICATE of bug 235461

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See comments in bug 175540.  The code in question is:

NS_ASSERTION(total <= 1, "This code probably leaks.  Please break out of the
loop or something, ok?");
for (i = 0; i < total; i++)
{
	nsCOMPtr<nsIRDFResource> mailList = do_QueryElementAt(pAddressLists, i);
	if (mailList)
		NS_ADDREF(*target = mailList);
	else
		return NS_RDF_NO_VALUE;
}

The assertion says it all; this leaks if mailList ever tests true twice in a
single iteration of the loop.

Comment 1

[Daniel Bratell]

If you want the last, why not just reverse the loop?

Comment 2

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 3

[jpl24]

It looks like this was fixed by Scott in bug 235461. Suggest duping to that bug
which is resolved fixed. LXR confirms this function was fixed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

*** This bug has been marked as a duplicate of 235461 ***