1812124 - Save as PDF does not work in Reader View

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, defect, P5)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/27641.

Steps to reproduce

1. Open the url https://en.m.wikipedia.org/wiki/Firefox
2. Click on the icon to toogle into the Reader View
3. Click on the menu (three dots ...) and share icon
4. Click on the Save as PDF
5. The dialog for the file download appears, click on the Download

Expected behaviour

The pdf file is downloaded

Actual behaviour

The message Firefox Nigthly can't dowload this file type appears.

Device name

motorola moto g 7 power

Android version

Android 10

Firefox release type

Firefox Nightly

Firefox version

108.0a1

Device logs

No response

Additional information

It happens on all sites I have tried. In the normal mode (without the switching to the Reader View) it works, i.e. I can save these sites as the pdf file.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812124 - Allow saving ReaderView as PDF (#1905)

Comment 3

[Jeff Boek [:boek]]

We need to check this again once we finish implementing the Metadata API to see if that fixes this.

Comment 4

[jackyzy823]

I'm not sure i understand implementing the Metadata API correctly.

If implementing the Metadata API means re-use the existing actors AboutReaderParent and AboutReaderChild. (from https://bugzilla.mozilla.org/show_bug.cgi?id=1770988). Then the problem will not be fixed.

Because the URL of AboutReader' "Save to PDF" is also not downloadable within FetchDownloadManager.kt. The URL is like "about:reader?url=xxxxx". You can observe it from header part from Desktop's Print Dialog.

Comment 5

[BMO Github Automation]

Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/f23c94de809ffe068e421cdf89ee3fcb6ad6b1ae
[main] Bug 1812124 - Allow moz-extension scheme in FetchDownloadManager

Comment 6

[Andrei Mocirean]

Verified as fixed on the latest Nightly (114.0a1) from 7th of May 2023.
Tested on: Google Pixel 7 (Android 13), Lenovo Tab P11 Plus (Android 12).
Thanks!