1812132 - Support structref and other heap types in ToWebAssembly value

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[bashor]

Attachment: kotlin-wasm.zip

Checked in the recent nightly build of Firefox 111.0a1 (2023-01-24).
It works fine in Chrom Canary.

Steps to reproduce:
Open index.html from the attachment

Actual results:
TypeError: cannot pass v128 to or from JS

Expected results:
No errors

Comment 1

[bashor]

Attachment: dbmonster.zip

Another axample

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rhunt, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Ryan Hunt [:rhunt]]

It looks like this example uses imports with structref in it. We don't support that in ToWasmValue/ToJSValue yet.

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1812132 - wasm: Allow anyref, structref, arrayref, and (ref T) in ToWasmValue/ToJSValue. r?jseward

The minimal JS-API spec for the GC proposal allows these types to be used on the
JS-Wasm boundary. So far we have not supported this. This commit updates these
methods so that the types work. This commit does not add support to our JIT
fast paths for exit/entry, so any use of these types will be stuck in the
interpreter entry/exit.

Comment 5

[Ryan Hunt [:rhunt]]

The attached patch fixes the error and gets the DOMMonster benchmark running in baseline. For Ion, we have a codegen issue that is causing a crash.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bedc72a2b77
wasm: Allow anyref, structref, arrayref, and (ref T) in ToWasmValue/ToJSValue. r=jseward

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4bedc72a2b77