Convert JSMs in browser/components/attribution to ESMs
Categories
(Firefox :: Installer, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: kpatenio, Assigned: portiawuu)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [esmification-timeline])
Attachments
(1 file)
There are two JSMs that need to be converted to ESMs:
|
||
Updated•1 year ago
|
|
||
Updated•1 year ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d0223fcdc02 Convert JSMs in browser/components/attribution to ESMs. r=mconley,kpatenio,nalexander
|
||
Comment 3•1 year ago
|
||
Backed out changeset 0d0223fcdc02 (Bug 1812141) for xpcshelll failures on test_ClientEnvironment.js.
Backout link
Push with failures <--> X2
Failure Log
The error occurs because of this assertion: https://searchfox.org/mozilla-central/rev/5ccb73c0217d1710b10d6e6e297cf3396d10ec23/toolkit/components/utils/test/unit/test_ClientEnvironment.js#82-83. If we read the entire message for the error caught in the catch block, it reads: "Error: Failed to load resource:///modules/AttributionCode.sys.mjs". The test expects a failure, but it appears that the error type changes a bit after conversion to an ESM. So the assertion fails because we're assuming a NS error result; instead we're just reading "Error". There's already support for ns errors though, as suggested, for example, by: https://searchfox.org/mozilla-central/rev/5ccb73c0217d1710b10d6e6e297cf3396d10ec23/js/xpconnect/tests/unit/test_import_es6_modules.js#22,29.
I suspect the fix is to update the assertion for that test in unit/test_ClientEnvironment.js by ensuring that ex.result == Cr.NS_ERROR_FILE_NOT_FOUND instead.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bd87c32d41b Convert JSMs in browser/components/attribution to ESMs. r=mconley,kpatenio,nalexander
|
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
Description
•