1812156 - Fully qualify type names in IPDL more reliably

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

Right now we have some using statements in IPDL code which do not correctly specify the full namespace of the type being imported. For example, ServiceWorkerState here (https://searchfox.org/mozilla-central/rev/f1dc2743777711c821d43f9911ee7c4447d60c8e/dom/serviceworkers/ServiceWorkerOpArgs.ipdlh#11,23), should be qualified as mozilla::dom::ServiceWorkerState, but happens to build because it is only used in that namespace. We should make fully qualified names in IPDL be generated with a leading :: so that we are more confident that the types are correctly namespaced when using statements are written.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

A few use using class mozilla::Foo or what not, which might make it tricky.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1812156 - Part 1: Fix some IPDL statements to use fully qualified names, r=#ipc-reviewers

These types were used in IPDL but were not fully qualified.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1812156 - Part 2: Require all IPDL using statements to be fully qualified, r=#ipc-reviewers

This is done by changing the formatting of QualifiedIds in the compiler
to include a leading ::, anchoring the path in the global namespace.
This means that the generated code will fail to recognize imports by
relative paths, as they will not be found in the correct namespace.

This required no longer using QualifiedId in TypeSpec, as that type is
generally used for local types in IPDL, which are never qualified in a
namespace (only using statements actually support being qualified). As
part of this, I also removed the unnecessary wrapper TypeSpec from using
statements, which was never used.

Finally, this also required changing how we handle builtin imports for
the C primitive types, as these types (such as int, bool, or
double) are special keywords, and can't be named in the global
namespace. They are now given a new builtin type name for C builtins,
and defined separately from other using statements.

This change also means that typedefs will now appear in generated code
for types in the global namespace, but this is required to double-check
that the type is actually in the global namespace.

Depends on D168877

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85dbc47c6fb0
Part 1: Fix some IPDL statements to use fully qualified names, r=necko-reviewers,valentin

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/85dbc47c6fb0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2208cd8db3ca
Part 2: Require all IPDL using statements to be fully qualified, r=ipc-reviewers,mccr8

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2208cd8db3ca

Comment 8

[Nika Layzell [:nika] (ni? for response)]

This was actually fixed when I landed the second part.