1812181 - Firefox for Android crashes submitting form

Status: NEW

(Firefox for Android :: Browser Engine, defect)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/27863.

On myprevea.com, attempting to make a payment. I enter my payment details, tap Submit, and Firefox crashes to Android home screen.

8567fb38-eb0c-4efe-b38b-d27163e88f5d
java.lang.IllegalStateException: Fragment CreditCardSaveDialogFragment{ecfb7a6} (359434e7-2c87-4af5-9f08-26406a3d393c) not attached to a context.

java.lang.IllegalStateException: Fragment CreditCardSaveDialogFragment{ecfb7a6} (359434e7-2c87-4af5-9f08-26406a3d393c) not attached to a context.
at androidx.fragment.app.Fragment.requireContext(Fragment.java:2)
at mozilla.components.feature.prompts.creditcard.CreditCardSaveDialogFragment$updateUI$1$1.invokeSuspend(CreditCardSaveDialogFragment.kt:6)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:4)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7898)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@b7de1f5, Dispatchers.IO]

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Chris Peterson [:cpeterson]]

This crash looks like an instance of bug 1646250.

Christian says this code "needs a check to see if the fragment is still attached when the IO operation completes."

Maybe someone should audit all our use of fragments.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

:jonalmeida, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 3

[Jonathan Almeida [:jonalmeida]]

The overall crash signature is increasing, but this one in particular on the CreditCardSaveDialogFragment is still low volume.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit BugBot documentation.

Comment 5

[Mira Lobontiu (Android QA)]

Hello all!
I was not able to reproduce tha crash on the latest Beta 125.0a1, nor on Nightly 125.0a1 from 3/18 with the following devices:

• Xiaomi mi8 Lite (Android 10), and
• Oppo Find N2 Flip (Android 13).

The "Save this card" prompt was displayed, and I was able to save the card, or tap the "Not now" option without crashing the app.

Comment 6

[Chris Peterson [:cpeterson]]

Clearing Priority so we can reprioritize these bugs relative to our ux-fun-2024 bugs.

Comment 7

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 8

[Denis Müller [:Webworkr]]

https://crash-stats.mozilla.org/report/index/a1653e07-b3de-4594-a4c9-6006e0240523

Comment 9

[Daniel Veditz [:dveditz]]

Why are you highlighting that months-old crash from May 23, 2024? Is there some unique information you're trying to point out?

Comment 10

[Daniel Veditz [:dveditz]]

Yours isn't even the same crash as the one in comment 0! (there's no CreditCardSaveDialogFragment on the stack)

Comment 11

[Denis Müller [:Webworkr]]

The crash report links to this ticket, among others. I originally assumed that adding the link here would add value. I have since been proven wrong. Sorry!