1812218 - [wpt-sync] Sync PR 38158 - webauthn: use SyntaxError for invalid credential IDs.

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38158 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38158
Details from upstream follow.

Adam Langley <[e-mail]> wrote:

webauthn: use SyntaxError for invalid credential IDs.

This reflects the discussion on the PR:
https://github.com/w3c/webauthn/pull/1836#discussion_r1069668151

Bug: 1106961
Change-Id: If68bd707a6aadfaf0e6de87e80b82de38396b9a0

Reviewed-on: https://chromium-review.googlesource.com/4193255
WPT-Export-Revision: f67af24e4482b7e6a07e83046541e7b8a5e71746

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ab43d204db5b93d5910b9378ad0926d0adbaaed

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 7

Chrome

OK : 1
PASS : 1
FAIL : 8

Safari

OK : 1
PASS : 1
FAIL : 8

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /webauthn/getcredential-prf.https.html [wpt.fyi]: TIMEOUT

New Tests That Don't Pass

• /webauthn/getcredential-prf.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • navigator.credentials.get() with single evaluation point: TIMEOUT (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() with two equal evaluation points: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() with two distinct evaluation points: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() using credential ID with one evaluation point: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() using credential ID with two evaluation points: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() using wrong credential ID: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() using invalid base64url credential ID: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • navigator.credentials.get() with an empty allow list but also using evalByCredential: NOTRUN (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d894651debc0
[wpt PR 38158] - webauthn: use SyntaxError for invalid credential IDs., a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d894651debc0