1812219 - [wpt-sync] Sync PR 38159 - [FlexNG] MinBlockSizeShouldEncompassIntrinsicSize for flex rows

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38159 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38159
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[FlexNG] MinBlockSizeShouldEncompassIntrinsicSize for flex rows

Update the MinBlockSizeShouldEncompassIntrinsicSize() calculation for
flex row items to check if the container has an auto block-size
in addition to whether or not the cross-size of the item would be
the container size. Otherwise, we would fail to correctly expand
due to fragmentation in some cases.

See CL:3600998 for where the original logic was added.

Bug: 1409030
Change-Id: I45b5455f16c84e0d409ebbfa3bf1b0994aff2feb

Reviewed-on: https://chromium-review.googlesource.com/4193452
WPT-Export-Revision: 0e25e38947037db802ea9a3e2a531d330958ba22

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=88959a62c0ba8ae6f1bb936e8f1f320e0af25748

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-break/flexbox/nested-flex-item-expansion-in-mulicol.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0be4b50e8a57
[wpt PR 38159] - [FlexNG] MinBlockSizeShouldEncompassIntrinsicSize for flex rows, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e0ec96e47129
[wpt PR 38159] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0be4b50e8a57
https://hg.mozilla.org/mozilla-central/rev/e0ec96e47129