1812231 - waitForBackgroundTask is easy to misunderstand

Status: ASSIGNED

(Core :: JavaScript: GC, task, P1)

Description

[Paul Bone [:pbone]]

SliceBudgets can't be both unlimited and time budgets. So these three lines of code that create a deadline for .join() are dead. Which is good because now we know that the task is definitly complete when .join() returns and the code that follows it makes sense.

https://searchfox.org/mozilla-central/source/js/src/gc/GC.cpp#3735-3737

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1812231 - Remove dead code deadline calcuation r=jonco

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1812231 - Simplify branches and avoid taking a lock twice r=jonco

An incremental GC that set shouldPauseMutator=true could enter both if
statements and would end up taking the lock a second time unnecessarily.
This patch makes these branches exclusive and complete.

Depends on D167767

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The following patches are waiting for review from a reviewer who resigned from the review:

ID	Title	Author	Reviewer Status
D167767	Bug 1812231 - Remove dead code deadline calcuation r=jonco	pbone	jonco: Resigned from review
D167768	Bug 1812231 - Simplify branches and avoid taking a lock twice r=jonco	pbone	jonco: Resigned from review

:pbone, could you please find another reviewer?

For more information, please visit auto_nag documentation.