1812257 - Crash in [@ mozilla::dom::SessionHistoryEntry::Info]

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc]

Crash report: https://crash-stats.mozilla.org/report/index/63cd61d8-1715-4b99-85f1-973040230125

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0  xul.dll  mozilla::UniquePtr<mozilla::dom::SessionHistoryInfo, mozilla::DefaultDelete<mozilla::dom::SessionHistoryInfo> >::get const  mfbt/UniquePtr.h:286
0  xul.dll  mozilla::UniquePtr<mozilla::dom::SessionHistoryInfo, mozilla::DefaultDelete<mozilla::dom::SessionHistoryInfo> >::operator* const  mfbt/UniquePtr.h:277
0  xul.dll  mozilla::dom::SessionHistoryEntry::Info const  docshell/shistory/SessionHistoryEntry.h:383
0  xul.dll  mozilla::dom::LoadingSessionHistoryInfo::LoadingSessionHistoryInfo  docshell/shistory/SessionHistoryEntry.cpp:397
1  xul.dll  mozilla::MakeUnique  mfbt/UniquePtr.h:605
1  xul.dll  mozilla::dom::CanonicalBrowsingContext::CreateLoadingSessionHistoryEntryForLoad  docshell/base/CanonicalBrowsingContext.cpp:573
2  xul.dll  mozilla::net::DocumentLoadListener::Open  netwerk/ipc/DocumentLoadListener.cpp:722
3  xul.dll  mozilla::net::DocumentLoadListener::OpenDocument  netwerk/ipc/DocumentLoadListener.cpp:933
4  xul.dll  mozilla::net::DocumentChannelParent::Init  netwerk/ipc/DocumentChannelParent.cpp:69
4  xul.dll  mozilla::net::NeckoParent::RecvPDocumentChannelConstructor  netwerk/ipc/NeckoParent.cpp:286

Top crash in nightly 20230124213422
Changelog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=35f8b8a01747061995b4cdcc821c09f15936b9ea&tochange=ba77054848c41f869d9d6a8e1d2c6e02c39dc34a

Nightly updates stopped.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as blocking firefox111 (nightly). However, the bug still isn't assigned.

:sdetar, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 2

[Donal Meehan [:dmeehan]]

Setting 111 to fixed, regressor Bug 1804803 backed out of central

Comment 3

[Andrew McCreight [:mccr8]]

Oops, I didn't mean to close it, though hopefully it has gone away.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:peterv, since you are the author of the regressor, bug 1804803, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 5

[Andrew McCreight [:mccr8]]

I guess the bot doesn't like me, so I'll close this.

Comment 6

[Suhaib Mujahid [:suhaib]]

(In reply to Andrew McCreight [:mccr8] from comment #5)

I guess the bot doesn't like me

This is not allowed.

The bot marks the nightly version as affected because the bug was reopened and both release and beta versions are unaffected: https://wiki.mozilla.org/Release_Management/autonag#Update_Firefox_Status_flags_for_bugs_reopened_during_Nightly_cycle

The bot should have added a comment to explain why it is marking the version as affected. I filed an issue to follow up on this: https://github.com/mozilla/relman-auto-nag/issues/1854

Comment 7

[Andrew McCreight [:mccr8]]

Thanks for the explanation. Yeah, I eventually theorized that I could have changed it from Reopened to New and it would have stopped the bot but I figured I'd caused enough noise in the bug already.

It does look like the crash hasn't come back after that single build.