1812329 - Remove nsMenubarFrame

Status: RESOLVED FIXED

(Core :: XUL, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1812329 - Remove nsMenuBarFrame. r=smaug

This ended up being a lot more straight-forward than the menu changes.

TLDR:

• nsMenuBarFrame -> XULMenuBarElement
• nsMenuBarListener -> MenuBarListener

Rest should be rather straight-forward. I didn't want to export
MenuBarListener so moved some of its functions (the access key stuff)
over to LookAndFeel / KeyboardEvent.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1812329 - Move accesskey out of nsMenubarListener. r=smaug

This makes the following patch simpler.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0532ccefaa6f
Move accesskey out of nsMenubarListener. r=smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5464978a27a8
Remove nsMenuBarFrame. r=smaug

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1812329 - Improve cycle collection of the menubar listener. r=smaug

Otherwise we leak in some bc tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d663fc115ab9
Improve cycle collection of the menubar listener. r=smaug

Comment 7

[Iulian Moraru]

Backed out 2 changesets (5464978a27a8 and d663fc115ab9) for causing multiple leaks.

• Push with failures

• Push with failures after the fix landed

• Failure log for bytes leaked (AbstractWatcher, AsyncFreeSnowWhite, AtomSet, AudioChannelAgent, BackstagePass, ...)

• Failure log for bytes leaked (AbstractWatcher, AnimationTimeline, AsyncFreeSnowWhite, AtomSet, AudioChannelAgent, ...)

• Failure log for SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3 in MOZ_Crash

LATER EDIT: there are also multiple failures on browser_siteSpecificWorkArounds.js - Failure log

There are also multiple failures related to browser_blocking<something> which appeared later:
example 1;
example 2;
example 3;
example 4.

And failures on browser_partitionedLocalStorage.js - Failure log

• Backout link

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Move accesskey out of nsMenubarListener. r=smaug
https://hg.mozilla.org/mozilla-central/rev/0532ccefaa6f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c624797b9cf
Remove nsMenuBarFrame. r=smaug

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3a15e75bc39
Add missing null-check for the case where we can't reach our window root from detach() anymore.

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5c624797b9cf
https://hg.mozilla.org/mozilla-central/rev/f3a15e75bc39