1812368 - Truncate more URIs that we pass into marker payloads

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

We truncated some URIs in markers with Bug 1810055. But it looks like there are some more markers that are passing untruncated URIs.
Here's one: https://searchfox.org/mozilla-central/rev/df68a65540f2227e27a12ed0b491188e2927f6d5/layout/base/nsRefreshDriver.cpp#1765-1768

We also fix the underlying problem inside the profiler buffer with Bug 1803109 but it would be good to fix this individually as well.

Making this a security issue thinking that this crash could be exploited somehow. I think it would be hard to do, but better safe than sorry.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1812368 - Truncate the URLs we are passing into profiler markers r?julienw,mstange

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Truncate the URLs we are passing into profiler markers r=julienw
https://hg.mozilla.org/integration/autoland/rev/5f1a89577a82bf303df0e00e5c2f5ea63f45deff
https://hg.mozilla.org/mozilla-central/rev/5f1a89577a82