1812457 - we are unconditionally setting release-managers review on the patch when we detect the change, even when release-managers has already given an r+ review.

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[David Lawrence [:dkl]]

From Slack:
we are unconditionally setting release-managers review on the patch when we detect the change, even when release-managers has already given an r+ review. this is overwriting the release-managers approval status. we should be checking the status isn't already "accepted" and only set the review if it isn't

I think all we need to do is add a next if under this line and check that the $stack_revision->reviewers_raw contains an element with reviewerPHID == $release_managers_phid: https://github.com/mozilla-bteam/bmo/blob/master/extensions/PhabBugz/lib/Feed.pm#L431

Comment 1

[BMO Automation]

Attachment: [mozilla-bteam/bmo] Bug 1812457 - we are unconditionally setting release-managers review on the patch when we detect the change, even when release-managers has already given an r+ review. (#2007)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/ff5f984266c4e5f60b5c64ad08fa7d6ee160c3fd