1812490 - Crash in [@ mozilla::dom::ContentParent::GetNewOrUsedLaunchingBrowserProcess]

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/d34b578b-d546-40eb-bb67-4453c0230125

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (Late attempt to GetNewOrUsedLaunchingBrowserProcess!)

Top 10 frames of crashing thread:

0  libxul.so  mozilla::dom::ContentParent::GetNewOrUsedLaunchingBrowserProcess  dom/ipc/ContentParent.cpp:1055
1  libxul.so  mozilla::dom::ContentParent::GetNewOrUsedBrowserProcessAsync  dom/ipc/ContentParent.cpp:1127
2  libxul.so  mozilla::dom::RemoteWorkerManager::LaunchNewContentProcess  dom/workers/remoteworkers/RemoteWorkerManager.cpp:708
2  libxul.so  mozilla::detail::RunnableFunction<mozilla::dom::RemoteWorkerManager::LaunchNewContentProcess  xpcom/threads/nsThreadUtils.h:546
3  libxul.so  mozilla::RunnableTask::Run  xpcom/threads/TaskController.cpp:539
3  libxul.so  mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal  xpcom/threads/TaskController.cpp:852
4  libxul.so  mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal  xpcom/threads/TaskController.cpp:684
4  libxul.so  mozilla::TaskController::ProcessPendingMTTask  xpcom/threads/TaskController.cpp:462
4  libxul.so  mozilla::TaskController::InitializeInternal const  xpcom/threads/TaskController.cpp:188
4  libxul.so  mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal  xpcom/threads/nsThreadUtils.h:546

There was a big crash spike on this same build, so I don't know if this is some weird side effect of that or what.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

I think https://phabricator.services.mozilla.com/D167565 in bug 1811195 probably missed adding a AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed) guard at https://searchfox.org/mozilla-central/rev/e1b4aec181f4e630fd9b08ac29c1d00a56ae5eed/dom/workers/remoteworkers/RemoteWorkerManager.cpp#696-718 (which would need the guard because of async reasons even if there was a check added at the XXX at https://searchfox.org/mozilla-central/rev/e1b4aec181f4e630fd9b08ac29c1d00a56ae5eed/dom/workers/remoteworkers/RemoteWorkerManager.cpp#422-423).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1811195

Comment 3

[Jens Stutte [:jstutte]]

Attachment: Bug 1812490 - Check for shutdown when executing async launch request. r?#dom-worker-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/265ddb17e99d
Check for shutdown when executing async launch request. r=asuth

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/265ddb17e99d

Comment 8

[Intermittent Failures Robot]

11 failures in 3914 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-central: 3

Platform and build breakdown:

• windows10-32-2004-qr: 4
  • debug: 2
  • opt: 2
• windows10-64-2004-qr: 3
  • debug: 2
  • opt: 1
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 1
  • opt: 1
• linux1804-64-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1812490&startday=2023-01-23&endday=2023-01-29&tree=all