1812521 - Don't pass a customFormatterIndex for customFormatterBody

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

CLJS devtoolsFormatters array can be modified, which means that the formatter used for the header might not be in the same position when trying to expand the body.
As we rely on an index on the devtoolsFormatters array to retrieve the body, this can fail.

Let's not handle this with an index, but rather store the formatter entry in the object actor for easy retrieval later

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

Attachment: Bug 1812521 - [devtools] Don't rely on custom formatter index for body hook. r=ochameau.

Instead of keeping track of an index, store the formatter entry in
the object actor from customFormatterHeader so we can re-use it
in customFormatterBody.

Depends on D167382

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6886537fc9b
[devtools] Don't rely on custom formatter index for body hook. r=ochameau.

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a6886537fc9b