1812540 - Xray attribute doesn't have get/set prefix

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Description

[Tooru Fujisawa [:arai]]

Xray function created for WebIDL attribute uses the attribute's name as the function name,
and it lacks "get " or "set " prefix.

https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/dom/bindings/BindingUtils.cpp#1515-1520,1538-1540,1548-1549

static bool XrayResolveAttribute(
    JSContext* cx, JS::Handle<JSObject*> wrapper, JS::Handle<JSObject*> obj,
    JS::Handle<jsid> id, const Prefable<const JSPropertySpec>& pref,
    const JSPropertySpec& attrSpec,
    JS::MutableHandle<Maybe<JS::PropertyDescriptor>> desc,
    bool& cacheOnHolder) {
...
  JS::Rooted<JSObject*> getter(
      cx, XrayCreateFunction(cx, wrapper, attrSpec.u.accessors.getter.native, 0,
                             id));
...
    setter = XrayCreateFunction(cx, wrapper, attrSpec.u.accessors.setter.native,
                                1, id);

I'm going to use the xray function in bug 1806598 to check if given accessor is safe for eager evaluation,
but the machinery uses the function name as a map key, and the missing "get " prefix is slightly problematic (can workaround, but it would be better if the prefix is added by default)

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1812540 - Part 1: Add JS::ToGetterId and JS::ToSetterId. r?sfink!

Depends on D168342

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1812540 - Part 2: Add get/set prefix for Xray accessors. r?smaug!,nchevobbe!

Also remove the workaround to add get/set prefix in debugger.

Depends on D168512

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810ed5832764
Part 1: Add JS::ToGetterId and JS::ToSetterId. r=sfink
https://hg.mozilla.org/integration/autoland/rev/3b0e28b20def
Part 2: Add get/set prefix for Xray accessors. r=nchevobbe,peterv

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures in devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c4af9a62fcca732c7d39ea8bc8cdd36c37c4b046

Push with failures

Failure log: TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js | Test timed out

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9e469586319
Part 1: Add JS::ToGetterId and JS::ToSetterId. r=sfink
https://hg.mozilla.org/integration/autoland/rev/5c2b32e98bed
Part 2: Add get/set prefix for Xray accessors. r=nchevobbe,peterv

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e9e469586319
https://hg.mozilla.org/mozilla-central/rev/5c2b32e98bed